feat: add a --client flag to the canister#307
Merged
mergify[bot] merged 2 commits intomasterfrom Jan 14, 2020
Merged
Conversation
This means it be invoked like so: ``` dfx canister --client http://client_host:1234 install --all ``` (or any canister subcommand).
Contributor
|
Does this eliminate the setting of host name and port in the DFX JSOn file? Or just augment it by allowing you to specify the host:port at the command line? (Hopefully, the latter.) |
Contributor
Author
|
It overrides it. |
Contributor
Author
|
That means the latter, sorry :) |
eftychis
reviewed
Jan 10, 2020
| let subcommand = args.subcommand(); | ||
|
|
||
| // Need storage for ClientEnvironment ownership. | ||
| let mut _client_env: Option<ClientEnvironment<'_>> = None; |
Contributor
There was a problem hiding this comment.
couldn't you move this inside the branch? I guess it is a bit more readable (or does it complain that it does not move?)
Contributor
Author
There was a problem hiding this comment.
It reduces the depth of the code. You can add a commit to this branch if that’s blocking your review.
eftychis
approved these changes
Jan 10, 2020
Contributor
|
Hmm thought this was merged. |
dfinity-bot
added a commit
that referenced
this pull request
Jul 8, 2020
## Changelog for advisory-db: Branch: Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0) * [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967 * [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients * [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src * [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio * [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13. * [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead * [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2 * [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir * [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306)) * [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309)) * [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310)) * [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314)) * [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201) * [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error * [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321)) * [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311)) * [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322)) * [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304)) * [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323)) * [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317)) * [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324)) * [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307)) * [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325)) * [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen * [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment * [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326)) * [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone * [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329)) * [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs * [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
dfinity-bot
added a commit
that referenced
this pull request
Jul 9, 2020
## Changelog for advisory-db: Branch: Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0) * [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967 * [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients * [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src * [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio * [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13. * [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead * [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2 * [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir * [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306)) * [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309)) * [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310)) * [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314)) * [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201) * [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error * [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321)) * [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311)) * [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322)) * [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304)) * [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323)) * [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317)) * [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324)) * [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307)) * [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325)) * [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen * [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment * [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326)) * [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone * [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329)) * [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs * [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2020
## Changelog for advisory-db: Branch: Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0) * [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967 * [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients * [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src * [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio * [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13. * [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead * [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2 * [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir * [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306)) * [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309)) * [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310)) * [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314)) * [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201) * [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error * [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321)) * [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311)) * [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322)) * [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304)) * [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323)) * [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317)) * [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324)) * [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307)) * [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325)) * [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen * [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment * [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326)) * [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone * [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329)) * [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs * [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
dfinity-bot
added a commit
that referenced
this pull request
Oct 31, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@a0281556...897d4674](https://github.com/dfinity-lab/common/compare/a028155647870facf6638ae1ce2b81ce012903c0...897d4674debd73015bc0273bca2ac6cbb0943516) * [`27999d80`](https://github.com/dfinity-lab/common/commit/27999d80393630a7aa923547a5bf2c70c3e56271) niv cargo2nix: update 62afa7a1 -> 5b2fc62a ([dfinity-lab/common#307](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/307)) * [`897d4674`](https://github.com/dfinity-lab/common/commit/897d4674debd73015bc0273bca2ac6cbb0943516) niv cargo2nix: update 5b2fc62a -> 0bc2a9a3 ([dfinity-lab/common#311](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/311))
mergify bot
pushed a commit
that referenced
this pull request
Oct 31, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@a0281556...897d4674](https://github.com/dfinity-lab/common/compare/a028155647870facf6638ae1ce2b81ce012903c0...897d4674debd73015bc0273bca2ac6cbb0943516) * [`27999d80`](https://github.com/dfinity-lab/common/commit/27999d80393630a7aa923547a5bf2c70c3e56271) niv cargo2nix: update 62afa7a1 -> 5b2fc62a ([dfinity-lab/common#307](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/307)) * [`897d4674`](https://github.com/dfinity-lab/common/commit/897d4674debd73015bc0273bca2ac6cbb0943516) niv cargo2nix: update 5b2fc62a -> 0bc2a9a3 ([dfinity-lab/common#311](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/311))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means it be invoked like so:
(or any canister subcommand).