style(bootstrap): Make loading indicator pretty#305
Merged
Conversation
Author
|
My greatest work. |
hansl
approved these changes
Jan 10, 2020
Author
|
Yeah, |
Author
|
Got a test failing for some reason. |
eftychis
approved these changes
Jan 10, 2020
Author
|
Contributor
|
@stanleygjones This passes now. Please check as I resolved conflicts/modified. |
Contributor
|
I think it's a better idea to steer away from custom tags. |
Contributor
|
@stanleygjones Could we "DFINITY"vely decide on what the main DOM element is? I have time to discuss or could be during our standiup. |
Contributor
|
reping on this @stanleygjones @hansl |
Contributor
|
Well, in #324 I simply reference |
hansl
approved these changes
Feb 14, 2020
dfinity-bot
added a commit
that referenced
this pull request
Oct 28, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@33474647...65e45e53](https://github.com/dfinity-lab/common/compare/334746475ee307d5af3098fec9eb3580fc462f33...65e45e53d7aa2d0d4f97808a97a2b6eb35d0cd01) * [`1b338a18`](https://github.com/dfinity-lab/common/commit/1b338a1804a1f9264765a8ee6ca3ae3efd667bb8) use cargo test in cargo2nix ([dfinity-lab/common#303](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/303)) * [`82b4e8fb`](https://github.com/dfinity-lab/common/commit/82b4e8fb715eacae461d0154c673d67375dad7af) Add bors.toml * [`0d1072d3`](https://github.com/dfinity-lab/common/commit/0d1072d346851cfe573761194cf64c017cec4c2f) .github/workflows/niv-updater.yml: don't set the auto-rebase-then-merge label * [`27f99eb5`](https://github.com/dfinity-lab/common/commit/27f99eb5813efe43b2345fdff73773d21b786e52) bors.toml: actually require all-systems-go instead of all-jobs * [`65e45e53`](https://github.com/dfinity-lab/common/commit/65e45e53d7aa2d0d4f97808a97a2b6eb35d0cd01) .mergify.yml: remove now that we merge through Bors ([dfinity-lab/common#305](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/305))
mergify bot
pushed a commit
that referenced
this pull request
Oct 28, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@33474647...65e45e53](https://github.com/dfinity-lab/common/compare/334746475ee307d5af3098fec9eb3580fc462f33...65e45e53d7aa2d0d4f97808a97a2b6eb35d0cd01) * [`1b338a18`](https://github.com/dfinity-lab/common/commit/1b338a1804a1f9264765a8ee6ca3ae3efd667bb8) use cargo test in cargo2nix ([dfinity-lab/common#303](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/303)) * [`82b4e8fb`](https://github.com/dfinity-lab/common/commit/82b4e8fb715eacae461d0154c673d67375dad7af) Add bors.toml * [`0d1072d3`](https://github.com/dfinity-lab/common/commit/0d1072d346851cfe573761194cf64c017cec4c2f) .github/workflows/niv-updater.yml: don't set the auto-rebase-then-merge label * [`27f99eb5`](https://github.com/dfinity-lab/common/commit/27f99eb5813efe43b2345fdff73773d21b786e52) bors.toml: actually require all-systems-go instead of all-jobs * [`65e45e53`](https://github.com/dfinity-lab/common/commit/65e45e53d7aa2d0d4f97808a97a2b6eb35d0cd01) .mergify.yml: remove now that we merge through Bors ([dfinity-lab/common#305](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/305))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot