Skip to content

Comments

style(bootstrap): Make loading indicator pretty#305

Merged
hansl merged 4 commits intomasterfrom
sj/pretty-bootstrap
Feb 14, 2020
Merged

style(bootstrap): Make loading indicator pretty#305
hansl merged 4 commits intomasterfrom
sj/pretty-bootstrap

Conversation

@ghost
Copy link

@ghost ghost commented Jan 10, 2020

Screenshot

Screen Shot 2020-01-10 at 7 48 32 AM

@ghost ghost self-assigned this Jan 10, 2020
@ghost ghost requested a review from hansl January 10, 2020 15:50
@ghost
Copy link
Author

ghost commented Jan 10, 2020

My greatest work.

@ghost ghost marked this pull request as ready for review January 10, 2020 15:50
@ghost ghost self-requested a review as a code owner January 10, 2020 15:50
@ghost
Copy link
Author

ghost commented Jan 10, 2020

Yeah, <app> is deprecated. I was advocating for <main> but it sounds like that conflicts with LinkedUp somehow... I'm going to follow up in a separate PR.

@ghost
Copy link
Author

ghost commented Jan 10, 2020

Got a test failing for some reason.

@ghost
Copy link
Author

ghost commented Jan 10, 2020

not ok 10 dfx start serves a frontend
# (from function `assert_command' in file /nix/store/67fkrbqi4ns58gy8ragv13jlky55wb8s-e2e/utils/assertions.bash, line 23,
#  in test file /nix/store/67fkrbqi4ns58gy8ragv13jlky55wb8s-e2e/frontend.bash, line 24)
#   `assert_command curl http://localhost:8000 # 8000 = default port.' failed
# Fetching manifest https://sdk.dfinity.org/manifest.json
# You seem to be running an outdated version of dfx.
# 
# Current version: 0.4.11
# You are strongly encouraged to upgrade by running 'dfx upgrade'!
# Creating new project "e2e_project"...
# CREATE       e2e_project/dfx.json (321B)...
# CREATE       e2e_project/README.md (1.01KB)...
# CREATE       e2e_project/src/e2e_project/main.mo (107B)...
# CREATE       e2e_project/.gitignore (189B)...
# CREATE       e2e_project/package.json (251B)...
# CREATE       e2e_project/src/e2e_project/public/index.js (155B)...
# CREATE       e2e_project/webpack.config.js (1.76KB)...
# npm ERR! code ENOTFOUND
# npm ERR! errno ENOTFOUND
# npm ERR! network request to https://registry.npmjs.org/webpack failed, reason: getaddrinfo ENOTFOUND registry.npmjs.org registry.npmjs.org:443
# npm ERR! network This is a problem related to network connectivity.
# npm ERR! network In most cases you are behind a proxy or have bad network settings.
# npm ERR! network 
# npm ERR! network If you are behind a proxy, please make sure that the
# npm ERR! network 'proxy' config is set properly.  See: 'npm help config'
# 
# npm ERR! A complete log of this run can be found in:
# npm ERR!     /build/dfx-e2e-home-pZdT/.npm/_logs/2020-01-10T17_07_54_859Z-debug.log

@eftychis
Copy link
Contributor

eftychis commented Jan 17, 2020

@stanleygjones This passes now.

Please check as I resolved conflicts/modified.

@hansl
Copy link
Contributor

hansl commented Jan 24, 2020

create-react-app uses <div id="root"></div>. We could use id="app" or id="main".

I think it's a better idea to steer away from custom tags.

@hansl
Copy link
Contributor

hansl commented Jan 27, 2020

@stanleygjones Could we "DFINITY"vely decide on what the main DOM element is? I have time to discuss or could be during our standiup.

@eftychis
Copy link
Contributor

reping on this @stanleygjones @hansl

@ggreif
Copy link
Contributor

ggreif commented Feb 10, 2020

Well, in #324 I simply reference document.body.firstElementChild.

@hansl hansl merged commit 0dd4373 into master Feb 14, 2020
mergify bot pushed a commit that referenced this pull request Oct 28, 2020
@Dfinity-Anthony Dfinity-Anthony unassigned ghost Jun 18, 2021
@lwshang lwshang deleted the sj/pretty-bootstrap branch July 29, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants