Skip to content

feat: hide loading indicator when index.js arrives #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ggreif wants to merge 3 commits into from
Closed

feat: hide loading indicator when index.js arrives #324

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98b9ef9
feat: hide loading indicator when index.js arrives
ggreif Jan 17, 2020
9122b78
Merge branch 'master' into gabor/hide-load
ggreif Jan 27, 2020
f603295
Merge branch 'master' into gabor/hide-load
ggreif Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/userlib/js/bootstrap/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,10 @@ if (!canisterId) {
// Load index.js from the canister.
icHttpAgent.retrieveAsset(canisterId, 'index.js')
.then(content => {
document.body.firstElementChild.hidden = true; // "Loading ..."
Copy link
Contributor

@nikclayton-dfinity nikclayton-dfinity Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .hidden property isn't a CSS thing.

I suspect that using CSS:

document.body.firstElementChild.style.visibility = 'hidden';

will be less likely to break. Two other reasons to do this.

  1. You can use CSS classes (.hidden, .visible) with the appropriate rules, and then add/remove those classes with el.classList.remove / .add / .toggle

  2. Since it's CSS you can animate the removal -- slide out, fade out, etc.

const indexJs = new TextDecoder().decode(content);
const script = document.createElement('script');
script.innerText = indexJs;
document.head.appendChild(script);
setTimeout(() => { document.head.appendChild(script) }, 10);
});
}