Skip to content

Apply TemplateDotNetLibrary PR #67 - Agent and lint cleanup#76

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/apply-template-dotnet-library-pr-67
Mar 29, 2026
Merged

Apply TemplateDotNetLibrary PR #67 - Agent and lint cleanup#76
Malcolmnixon merged 2 commits intomainfrom
copilot/apply-template-dotnet-library-pr-67

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 29, 2026

Pull Request

Description

Ports TemplateDotNetLibrary#67 to this repository — replacing the monolithic role-based agents with a leaner standards-driven model and adding structured standards references.

Agent restructure:

  • Removed 5 old agents: code-quality, requirements, software-developer, technical-writer, test-developer
  • Added 3 new agents: developer (general-purpose, standards-based), implementation (RESEARCH→DEVELOPMENT→QUALITY→REPORT state machine), quality (compliance checklist grader)
  • Updated code-review and repo-consistency with structured workflow and .agent-logs/-based reporting (repo-consistency retains TemplateDotNetTool URL/project name)

New .github/standards/ directory with 6 reusable standards files agents load on demand:
csharp-language.md, csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, software-items.md, technical-documentation.md

AGENTS.md rewritten around the standards-delegation model; agent report convention moved from AGENT_REPORT_*.md to .agent-logs/[agent]-[subject]-[id].md

Tooling/config:

  • lint.sh / lint.bat: npm install --silent, pip install --quiet --disable-pip-version-check, cspell --quiet
  • .markdownlint-cli2.yaml: added noBanner and noProgress
  • .cspell.yaml, .gitignore, .markdownlint-cli2.yaml, .yamllint.yaml: exclude .agent-logs/
  • build.yaml: removed --definition .reviewmark.yaml (auto-discovered by ReviewMark)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.TemplateDotNetTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No functional code changes — agent/configuration files only.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:


⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

Copilot AI changed the title [WIP] Apply changes from TemplateDotNetLibrary PR #67 Apply TemplateDotNetLibrary PR #67 - Agent and lint cleanup Mar 29, 2026
Copilot AI requested a review from Malcolmnixon March 29, 2026 21:52
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 29, 2026 21:53
Copilot AI review requested due to automatic review settings March 29, 2026 21:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports TemplateDotNetLibrary PR #67 into this repo by restructuring Copilot agents around a standards-delegation model, adding reusable standards documents, and tightening lint/reporting noise and exclusions (including .agent-logs/).

Changes:

  • Replaced role-based agents with developer, implementation, and quality; updated code-review/repo-consistency and rewrote AGENTS.md to reference .github/standards/ and .agent-logs/ reporting.
  • Added .github/standards/ reference documents for C#, testing, ReqStream, ReviewMark, software item classification, and technical documentation.
  • Reduced linter output noise, excluded .agent-logs/ from linters/git, and simplified ReviewMark invocation in CI.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lint.sh Quieted npm/pip/cspell output to reduce lint noise.
lint.bat Same as lint.sh for Windows.
AGENTS.md Rewritten to standards-delegation model + .agent-logs/ reporting convention.
.yamllint.yaml Excludes .agent-logs/ from yamllint.
.markdownlint-cli2.yaml Suppresses banner/progress; excludes .agent-logs/.
.gitignore Ignores .agent-logs/.
.github/workflows/build.yaml Removes explicit ReviewMark definition argument (rely on discovery).
.github/standards/csharp-language.md New C# coding standards reference.
.github/standards/csharp-testing.md New MSTest testing standards reference.
.github/standards/reqstream-usage.md New ReqStream usage standards reference.
.github/standards/reviewmark-usage.md New ReviewMark usage standards reference.
.github/standards/software-items.md New software item categorization standards reference.
.github/standards/technical-documentation.md New technical documentation standards reference.
.github/agents/developer.agent.md New general-purpose standards-based dev agent.
.github/agents/implementation.agent.md New orchestrator/state-machine agent.
.github/agents/quality.agent.md New QA/checklist grading agent.
.github/agents/code-review.agent.md Updated formal review workflow + .agent-logs/ reporting path.
.github/agents/repo-consistency.agent.md Updated workflow + .agent-logs/ reporting format.
.github/agents/test-developer.agent.md Removed legacy role-based agent.
.github/agents/technical-writer.agent.md Removed legacy role-based agent.
.github/agents/software-developer.agent.md Removed legacy role-based agent.
.github/agents/requirements.agent.md Removed legacy role-based agent.
.github/agents/code-quality.agent.md Removed legacy role-based agent.
.cspell.yaml Excludes .agent-logs/ from spell checking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants