Apply TemplateDotNetTool PR #76 - Agent and lint cleanup

[Copilot]

Pull Request

Description

Ports TemplateDotNetTool#76 — replaces the monolithic role-based agent model with a leaner standards-delegation model.

Agent restructure:

• Removed 5 agents: code-quality, requirements, software-developer, technical-writer, test-developer
• Added 3 agents: developer (general-purpose, standards-based), implementation (RESEARCH→DEVELOPMENT→QUALITY→REPORT state machine), quality (compliance checklist grader)
• Updated code-review and repo-consistency to use .agent-logs/-based reporting

New .github/standards/ directory — 6 reusable standards files agents load on demand:

• csharp-language.md, csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, software-items.md, technical-documentation.md

AGENTS.md rewritten around the standards-delegation model; agent report convention moved from AGENT_REPORT_*.md to .agent-logs/[agent]-[subject]-[id].md

Tooling/config:

• lint.sh / lint.bat: replaced with template versions — installs npm and pip dependencies, runs all linters collecting errors before exiting (no set -e / fail-fast)
• pip-requirements.txt: added to support yamllint installation in lint scripts
• .gitignore: added .venv/ (present in template .gitignore) and .agent-logs/
• .markdownlint-cli2.yaml: added noBanner and noProgress
• .cspell.yaml, .markdownlint-cli2.yaml, .yamllint.yaml: exclude .agent-logs/
• build.yaml: removed --definition .reviewmark.yaml (auto-discovered by ReviewMark)

CI alignment with DEMA standards:

• ReviewMark output paths updated: review-plan.md → plan.md and review-report.md → report.md (and corresponding .html files) in build.yaml and definition.yaml files
• .gitignore updated to reference the correct standard ReviewMark output paths
• docs/guide/ renamed to docs/user_guide/ to match DEMA standard; all references updated in build.yaml, docs/user_guide/definition.yaml, AGENTS.md

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Self-validation tests pass:
  dotnet run --project src/DemaConsulting.VersionMark --configuration Release --framework net10.0
--no-build -- --validate
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

• Spell checker passes: cspell "**/*.{md,cs}"
• Markdown linter passes: markdownlint "**/*.md"
• YAML linter passes: yamllint .

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

No functional code changes — agent and configuration files only.

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[Copilot]

Pull request overview

Ports TemplateDotNetTool PR #76 into VersionMark by restructuring Copilot agents around a standards-delegation model, introducing reusable standards documents, and updating lint/CI configuration to reduce noise and ignore the new agent log directory.

Changes:

• Replaced the previous role-based agent set with developer, implementation, and quality, and updated code-review/repo-consistency guidance.
• Added .github/standards/ documentation to be loaded on-demand by agents; updated AGENTS.md accordingly.
• Updated linting/workflow configs to quiet output and exclude .agent-logs/ from linting and git tracking.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
lint.sh	Adds --quiet to cspell invocation to reduce output noise.
lint.bat	Adds --quiet to cspell invocation to reduce output noise.
AGENTS.md	Rewrites agent guidance to standards-delegation model and .agent-logs/ reporting.
.yamllint.yaml	Ignores .agent-logs/ during YAML linting.
.markdownlint-cli2.yaml	Disables banner/progress output; ignores .agent-logs/.
.gitignore	Ignores .agent-logs/ directory.
.github/workflows/build.yaml	Removes explicit ReviewMark --definition argument.
.github/standards/csharp-language.md	Adds reusable C# coding standards.
.github/standards/csharp-testing.md	Adds reusable MSTest standards and antipattern guidance.
.github/standards/reqstream-usage.md	Adds reusable ReqStream usage/quality guidance.
.github/standards/reviewmark-usage.md	Adds reusable ReviewMark usage/quality guidance.
.github/standards/software-items.md	Adds reusable software item categorization guidance.
.github/standards/technical-documentation.md	Adds reusable technical documentation standards and doc-structure guidance.
.github/agents/repo-consistency.agent.md	Updates agent workflow + .agent-logs/ reporting template.
.github/agents/quality.agent.md	Adds new quality checklist agent.
.github/agents/implementation.agent.md	Adds new implementation orchestrator agent (state machine).
.github/agents/developer.agent.md	Adds new general-purpose developer agent.
.github/agents/code-review.agent.md	Updates formal review guidance and report template.
.github/agents/requirements.agent.md	Removes deprecated role-based agent.
.github/agents/software-developer.agent.md	Removes deprecated role-based agent.
.github/agents/test-developer.agent.md	Removes deprecated role-based agent.
.github/agents/technical-writer.agent.md	Removes deprecated role-based agent.
.github/agents/code-quality.agent.md	Removes deprecated role-based agent.
.cspell.yaml	Excludes .agent-logs/ from spell checking.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Malcolmnixon]

@copilot Not sure why you checked in the .venv but you need to get that crap out of the commit - also check why you even thought it was appropriate considering the template .gitignore excludes it.

[Copilot]

@copilot Not sure why you checked in the .venv but you need to get that crap out of the commit - also check why you even thought it was appropriate considering the template .gitignor...

Root cause: the f5c90f0 commit missed adding .venv/ to the Python section of .gitignore (the template's .gitignore has it). When I ran the new lint.sh to validate, it created .venv/, and report_progress committed everything since it wasn't gitignored.

It was removed from tracking in e8e30c8 and .venv/ is now in .gitignore. The net PR diff has 0 .venv files from the base branch to HEAD.

Removing those intermediate commits requires a force-push, which the push mechanism here doesn't support (it does a fetch+rebase). The commits 28f48e6 and e8e30c8 remain in the branch history but the PR's net diff is clean.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)