Apply TemplateDotNetTool PRs #76, #77, and #78 - Standards-driven agent restructure and docs reorganization by Copilot · Pull Request #34 · demaconsulting/ReviewMark

Copilot · 2026-03-29T23:26:01Z

Pull Request

Description

Ports TemplateDotNetTool#76 and TemplateDotNetTool#77 into this repository — replacing monolithic role-based agents with a leaner standards-delegation model and adding explicit markdown formatting guidance. Also renames the user guide documentation folder for consistency with the standards.

Agent restructure (PR #76):

Removed 5 old agents: code-quality, requirements, software-developer, technical-writer, test-developer
Added 3 new agents: developer (standards-based), implementation (RESEARCH→DEVELOPMENT→QUALITY→REPORT state machine), quality (compliance checklist grader)
Updated code-review and repo-consistency to use .agent-logs/-based reporting

New .github/standards/ directory (PR #76) — 6 reusable standards files agents load on demand:
csharp-language.md, csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, software-items.md, technical-documentation.md

AGENTS.md (PR #76) rewritten around standards-delegation model; agent report convention moved from AGENT_REPORT_*.md → .agent-logs/[agent]-[subject]-[id].md

Tooling/config (PR #76):

lint.sh / lint.bat: npm install --silent, pip install --quiet --disable-pip-version-check, cspell --quiet
.markdownlint-cli2.yaml: added noBanner and noProgress
.cspell.yaml, .gitignore, .markdownlint-cli2.yaml, .yamllint.yaml: exclude .agent-logs/
build.yaml: removed --definition .reviewmark.yaml (auto-discovered by ReviewMark)

Markdown format requirements (PR #77): Added a "Markdown Format Requirements" section to .github/standards/technical-documentation.md documenting the formatting rules enforced by .markdownlint-cli2.yaml (120-character line limit, no trailing whitespace, blank lines around headings/lists, ATX-style headers, 2-space list indentation).

User guide folder rename: Renamed docs/guide/ → docs/user_guide/ and guide.md → introduction.md to align with the docs/ structure described in the standards. Updated all references in docs/user_guide/definition.yaml, .github/workflows/build.yaml, README.md, AGENTS.md, and .reviewmark.yaml.

Post-merge repo-consistency check confirmed no additional template drift to address.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

Code builds successfully: dotnet build --configuration Release
All unit tests pass: dotnet test --configuration Release
Self-validation tests pass:
dotnet run --project src/DemaConsulting.ReviewMark --configuration Release --framework net10.0
--no-build -- --validate
Code produces zero warnings

Code Quality

Code formatting is correct: dotnet format --verify-no-changes
New code has appropriate XML documentation comments
Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

Spell checker passes: cspell "**/*.{md,cs}"
Markdown linter passes: markdownlint "**/*.md"
YAML linter passes: yamllint .

Testing

Added unit tests for new functionality
Updated existing tests if behavior changed
All tests follow the AAA (Arrange, Act, Assert) pattern
Test coverage is maintained or improved

Documentation

Updated README.md (if applicable)
Updated ARCHITECTURE.md (if applicable)
Added code examples for new features (if applicable)
Updated requirements.yaml (if applicable)

Additional Notes

No functional code changes — agent/configuration and documentation files only.

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Agent-Logs-Url: https://github.com/demaconsulting/ReviewMark/sessions/5e347cdf-1fe1-49e2-81c0-7f3ad8fa994c Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Malcolmnixon · 2026-03-30T03:03:04Z

@copilot Please also include demaconsulting/TemplateDotNetTool#77

… technical-documentation.md Agent-Logs-Url: https://github.com/demaconsulting/ReviewMark/sessions/80fe8d02-e5bc-44a7-ab7f-d0cec390ce31 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-30T03:05:40Z

@copilot Please also include demaconsulting/TemplateDotNetTool#77

Done in b49bdca. Added the "Markdown Format Requirements" section to .github/standards/technical-documentation.md from PR #77 (120-character line limit, no trailing whitespace, blank lines around headings/lists, ATX-style headers, 2-space list indentation).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Ports TemplateDotNetTool PRs #76/#77 into ReviewMark to replace role-based agent files with a standards-delegation model, introduce reusable standards documents, and formalize agent logging + markdown formatting guidance.

Changes:

Replaced legacy specialized agents with a smaller set of standards-driven agents and updated AGENTS.md guidance + log/report conventions.
Added .github/standards/ documents (C#, testing, ReqStream, ReviewMark, software item categorization, technical docs) and excluded .agent-logs/ from linting/spellcheck/YAML lint.
Reduced lint/build noise (quiet/silent flags) and updated CI ReviewMark invocation to rely on default .reviewmark.yaml discovery.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`lint.sh`	Makes npm/pip/cspell output quieter for cleaner lint logs.
`lint.bat`	Windows equivalent: quieter npm/pip/cspell runs.
`AGENTS.md`	Rewrites agent guidance around standards delegation and `.agent-logs/` reporting.
`.yamllint.yaml`	Excludes `.agent-logs/` from YAML lint.
`.markdownlint-cli2.yaml`	Suppresses markdownlint banner/progress and ignores `.agent-logs/`.
`.gitignore`	Ignores `.agent-logs/` (new agent reporting location).
`.github/workflows/build.yaml`	Removes explicit `--definition .reviewmark.yaml` from ReviewMark step (use default discovery).
`.github/standards/technical-documentation.md`	Adds technical documentation standards + markdown formatting requirements.
`.github/standards/software-items.md`	Defines software item categorization standards.
`.github/standards/reviewmark-usage.md`	Defines ReviewMark usage standards (review-sets, patterns, commands).
`.github/standards/reqstream-usage.md`	Defines ReqStream requirements/traceability standards.
`.github/standards/csharp-testing.md`	Establishes MSTest/AAA/naming/antipattern guidance.
`.github/standards/csharp-language.md`	Establishes C# literate style, XML docs, DI, error handling standards.
`.github/agents/test-developer.agent.md`	Removes legacy role-based agent definition.
`.github/agents/technical-writer.agent.md`	Removes legacy role-based agent definition.
`.github/agents/software-developer.agent.md`	Removes legacy role-based agent definition.
`.github/agents/requirements.agent.md`	Removes legacy role-based agent definition.
`.github/agents/code-quality.agent.md`	Removes legacy role-based agent definition.
`.github/agents/repo-consistency.agent.md`	Updates repo consistency agent to standards workflow + `.agent-logs/` reporting format.
`.github/agents/quality.agent.md`	Adds new quality checklist/grading agent.
`.github/agents/implementation.agent.md`	Adds orchestrator agent with RESEARCH→DEVELOPMENT→QUALITY→REPORT state machine.
`.github/agents/developer.agent.md`	Adds standards-driven general development agent.
`.github/agents/code-review.agent.md`	Updates formal review process and switches reporting to `.agent-logs/`.
`.cspell.yaml`	Excludes `.agent-logs/` from spell checking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/standards/technical-documentation.md

Malcolmnixon · 2026-03-30T03:16:18Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/demaconsulting/ReviewMark/sessions/c4adc73c-69b1-4b10-b8e5-c37e5d901ffa Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-30T03:19:32Z

@copilot apply changes based on the comments in this thread

Done in 6a26ac0. Renamed docs/guide/ → docs/user_guide/ and guide.md → introduction.md, and updated all references in docs/user_guide/definition.yaml, .github/workflows/build.yaml, README.md, AGENTS.md, and .reviewmark.yaml.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Initial plan

ff92468

Copilot AI assigned Copilot and Malcolmnixon Mar 29, 2026

Copilot started work on behalf of Malcolmnixon March 29, 2026 23:26 View session

Apply TemplateDotNetTool PR #76 - Agent and lint cleanup

0ab49f4

Agent-Logs-Url: https://github.com/demaconsulting/ReviewMark/sessions/5e347cdf-1fe1-49e2-81c0-7f3ad8fa994c Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Merge changes from PR 76 into current repository~~ Apply TemplateDotNetTool PR #76 - Standards-driven agent restructure Mar 29, 2026

Copilot finished work on behalf of Malcolmnixon March 29, 2026 23:44

Copilot AI requested a review from Malcolmnixon March 29, 2026 23:44

Copilot started work on behalf of Malcolmnixon March 30, 2026 03:03 View session

Copilot AI changed the title ~~Apply TemplateDotNetTool PR #76 - Standards-driven agent restructure~~ Apply TemplateDotNetTool PRs #76 and #77 - Standards-driven agent restructure Mar 30, 2026

Copilot finished work on behalf of Malcolmnixon March 30, 2026 03:06

Malcolmnixon marked this pull request as ready for review March 30, 2026 03:08

Copilot AI review requested due to automatic review settings March 30, 2026 03:08

Copilot started reviewing on behalf of Malcolmnixon March 30, 2026 03:08 View session

Malcolmnixon approved these changes Mar 30, 2026

View reviewed changes

Copilot AI reviewed Mar 30, 2026

View reviewed changes

.github/standards/technical-documentation.md Show resolved Hide resolved

.github/standards/technical-documentation.md Show resolved Hide resolved

Copilot started work on behalf of Malcolmnixon March 30, 2026 03:16 View session

Copilot AI changed the title ~~Apply TemplateDotNetTool PRs #76 and #77 - Standards-driven agent restructure~~ Apply TemplateDotNetTool PRs #76, #77, and #78 - Standards-driven agent restructure and docs reorganization Mar 30, 2026

Copilot finished work on behalf of Malcolmnixon March 30, 2026 03:20

Copilot AI requested a review from Malcolmnixon March 30, 2026 03:20

Malcolmnixon merged commit e07fa7f into main Mar 30, 2026
15 checks passed

Malcolmnixon deleted the copilot/merge-pull-76-into-repo branch March 30, 2026 03:32

This was referenced Apr 6, 2026

Bump the nuget-dependencies group with 7 updates demaconsulting/NuGetCaching#33

Merged

Bump the nuget-dependencies group with 8 updates demaconsulting/SarifMark#92

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply TemplateDotNetTool PRs #76, #77, and #78 - Standards-driven agent restructure and docs reorganization#34

Apply TemplateDotNetTool PRs #76, #77, and #78 - Standards-driven agent restructure and docs reorganization#34
Malcolmnixon merged 4 commits intomainfrom
copilot/merge-pull-76-into-repo

Copilot AI commented Mar 29, 2026 •

edited

Loading

Uh oh!

Malcolmnixon commented Mar 30, 2026

Uh oh!

Copilot AI commented Mar 30, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Malcolmnixon commented Mar 30, 2026

Uh oh!

Copilot AI commented Mar 30, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Description

Type of Change

Related Issues

Pre-Submission Checklist

Build and Test

Code Quality

Quality Checks

Testing

Documentation

Additional Notes

Uh oh!

Malcolmnixon commented Mar 30, 2026

Uh oh!

Copilot AI commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Malcolmnixon commented Mar 30, 2026

Uh oh!

Copilot AI commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 29, 2026 •

edited

Loading

Copilot AI commented Mar 30, 2026 •

edited

Loading

Copilot AI commented Mar 30, 2026 •

edited

Loading