Skip to content

Extensive agent and lint cleanup#67

Merged
Malcolmnixon merged 26 commits intomainfrom
agent-cleanup
Mar 29, 2026
Merged

Extensive agent and lint cleanup#67
Malcolmnixon merged 26 commits intomainfrom
agent-cleanup

Conversation

@Malcolmnixon
Copy link
Copy Markdown
Member

Pull Request

Description

Cleanup of agents for better orchestration, standards-following, and logging.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

N/A

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

N/A

Copilot AI review requested due to automatic review settings March 29, 2026 19:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleanup and consolidation of the repository’s AI agent ecosystem to improve orchestration, standardization, and logging, including the addition of formal standards documents under .github/standards/ and a new .agent-logs/ convention.

Changes:

  • Replaced multiple specialized agents with a smaller set of orchestrated agents (developer, quality, implementation) and updated existing agent guidance.
  • Added a new standards library under .github/standards/ (C#, testing, ReqStream, ReviewMark, software categorization, documentation).
  • Introduced .agent-logs/ as the canonical location for agent output logs and excluded it from git + linters.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
AGENTS.md Updates agent delegation model, points to standards, and introduces .agent-logs/ logging convention.
.yamllint.yaml Excludes .agent-logs/ from YAML linting.
.markdownlint-cli2.yaml Excludes .agent-logs/ from markdownlint scanning.
.gitignore Ignores .agent-logs/ so agent logs aren’t committed.
.cspell.yaml Excludes .agent-logs/ from spell-checking.
.github/standards/technical-documentation.md Adds documentation structure and quality rules (Pandoc/README/auto-generated content).
.github/standards/software-items.md Defines system/subsystem/unit/OTS categorization standard.
.github/standards/reviewmark-usage.md Documents ReviewMark review-set conventions and commands.
.github/standards/reqstream-usage.md Documents ReqStream requirements organization, IDs, and traceability rules.
.github/standards/csharp-testing.md Establishes MSTest AAA/naming conventions and anti-pattern guidance.
.github/standards/csharp-language.md Establishes literate-style, XML docs, DI, and error handling standards for C#.
.github/agents/test-developer.agent.md Removes legacy specialized agent.
.github/agents/technical-writer.agent.md Removes legacy specialized agent.
.github/agents/software-developer.agent.md Removes legacy specialized agent.
.github/agents/requirements.agent.md Removes legacy specialized agent.
.github/agents/code-quality.agent.md Removes legacy specialized agent.
.github/agents/repo-consistency.agent.md Updates workflow guidance and moves reporting to .agent-logs/.
.github/agents/quality.agent.md Adds new QA/grading agent with standards-driven checklist and report template.
.github/agents/implementation.agent.md Adds new state-machine orchestrator agent for research→dev→quality→report.
.github/agents/developer.agent.md Adds new general-purpose development agent driven by standards selection.
.github/agents/code-review.agent.md Updates formal review workflow steps and reporting path under .agent-logs/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 11 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 29, 2026 20:03
Malcolmnixon and others added 7 commits March 29, 2026 16:04
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 29, 2026 20:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 29, 2026 20:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Malcolmnixon and others added 2 commits March 29, 2026 16:34
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 29, 2026 20:39
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Malcolmnixon and others added 3 commits March 29, 2026 16:39
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 29, 2026 21:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 29, 2026 21:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malcolmnixon Malcolmnixon changed the title Extensive agent cleanup Extensive agent and lint cleanup Mar 29, 2026
@Malcolmnixon Malcolmnixon merged commit 478c299 into main Mar 29, 2026
10 checks passed
@Malcolmnixon Malcolmnixon deleted the agent-cleanup branch March 29, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants