Skip to content

Apply TemplateDotNetTool PR #76 - Agent and lint cleanup#140

Merged
Malcolmnixon merged 3 commits intomainfrom
copilot/merge-pr-76
Mar 29, 2026
Merged

Apply TemplateDotNetTool PR #76 - Agent and lint cleanup#140
Malcolmnixon merged 3 commits intomainfrom
copilot/merge-pr-76

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 29, 2026

Pull Request

Description

Ports TemplateDotNetTool#76 into this repository — replacing monolithic role-based agents with a leaner standards-driven model and adding .agent-logs/ exclusions across tooling config.

Agent restructure:

  • Removed 5 old agents: code-quality, requirements, software-developer, technical-writer, test-developer
  • Added 3 new agents: developer (general-purpose, standards-based), implementation (RESEARCH→DEVELOPMENT→QUALITY→REPORT state machine), quality (compliance checklist grader)
  • Updated code-review and repo-consistency with structured workflow and .agent-logs/-based reporting

New .github/standards/ directory with 6 reusable standards files agents load on demand:
csharp-language.md, csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, software-items.md, technical-documentation.md

AGENTS.md rewritten around the standards-delegation model.

Tooling/config:

  • lint.sh / lint.bat: added --silent (npm), --quiet --disable-pip-version-check (pip), --quiet (cspell)
  • .markdownlint-cli2.yaml: added noBanner and noProgress
  • .cspell.yaml, .gitignore, .markdownlint-cli2.yaml, .yamllint.yaml: exclude .agent-logs/
  • build.yaml: removed --definition .reviewmark.yaml (auto-discovered by ReviewMark)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.ReqStream --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No functional code changes — agent/configuration files only.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh pr view 76 --repo demaconsulting/TemplateDotNetTool --json title,body,files (http block)
  • https://api.github.com/repos/demaconsulting/TemplateDotNetTool/contents/.github/agents
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)
  • https://api.github.com/repos/demaconsulting/TemplateDotNetTool/contents/.github/standards
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)
  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js --destination-port 53 -j ACCEPT st-netcore/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.dll (http block)

If you need me to access, download, or install something from one of these locations, you can either:


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI and others added 2 commits March 29, 2026 22:27
- Add `**/.agent-logs/**` to .cspell.yaml ignorePaths
- Add `.agent-logs/` to .gitignore
- Add noBanner/noProgress to .markdownlint-cli2.yaml; exclude .agent-logs/
- Add .agent-logs/ to .yamllint.yaml ignore list
- Remove old agents: code-quality, requirements, software-developer,
  technical-writer, test-developer
- Add new agents: developer, implementation, quality
- Update agents: code-review, repo-consistency (new .agent-logs/ reporting)
- Add .github/standards/ directory with 6 standards files
- Rewrite AGENTS.md around standards-delegation model
- Add --silent/--quiet flags to npm/pip commands in lint scripts
- Add --quiet flag to cspell in lint scripts
- Remove --definition .reviewmark.yaml from build.yaml (auto-discovered)
- Add antipatterns, nameof, passwordvalidator to cspell word list

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Agent-Logs-Url: https://github.com/demaconsulting/ReqStream/sessions/982228c4-b654-4cb5-9bb6-b564de496e88

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Merge pull request #76 from demaconsulting Apply TemplateDotNetTool PR #76 - Agent and lint cleanup Mar 29, 2026
Copilot AI requested a review from Malcolmnixon March 29, 2026 22:33
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 29, 2026 22:35
Copilot AI review requested due to automatic review settings March 29, 2026 22:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports TemplateDotNetTool#76’s “standards-driven” agent model into ReqStream, adds reusable standards docs under .github/standards/, and reduces/noises output from lint tooling while excluding .agent-logs/ across repo tooling configs.

Changes:

  • Restructure agent definitions: remove legacy role-based agents and add developer, implementation, quality, plus updates to code-review/repo-consistency.
  • Add .github/standards/*.md reference standards and rewrite AGENTS.md to delegate to those standards.
  • Quiet/suppress linter tool output and exclude .agent-logs/ from git + lint tools; simplify ReviewMark invocation in CI.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
lint.sh Quiet npm/pip/cspell output for CI readability.
lint.bat Quiet npm/pip/cspell output for CI readability (Windows).
AGENTS.md Rewritten guidance for standards-driven agents and .agent-logs/ reporting.
.yamllint.yaml Excludes .agent-logs/ from YAML linting.
.markdownlint-cli2.yaml Suppresses banner/progress; excludes .agent-logs/.
.gitignore Ignores .agent-logs/.
.github/workflows/build.yaml Removes explicit ReviewMark --definition arg.
.github/standards/csharp-language.md Adds C# coding standards reference.
.github/standards/csharp-testing.md Adds MSTest/AAA/testing standards reference.
.github/standards/reqstream-usage.md Adds ReqStream usage/requirements standards reference.
.github/standards/reviewmark-usage.md Adds ReviewMark usage standards reference.
.github/standards/software-items.md Adds software item categorization standards reference.
.github/standards/technical-documentation.md Adds documentation/Pandoc/README standards reference.
.github/agents/test-developer.agent.md Removes legacy agent definition.
.github/agents/technical-writer.agent.md Removes legacy agent definition.
.github/agents/software-developer.agent.md Removes legacy agent definition.
.github/agents/requirements.agent.md Removes legacy agent definition.
.github/agents/code-quality.agent.md Removes legacy agent definition.
.github/agents/developer.agent.md Adds new general-purpose standards-based agent.
.github/agents/implementation.agent.md Adds orchestration/state-machine agent.
.github/agents/quality.agent.md Adds standards compliance grading agent.
.github/agents/code-review.agent.md Updates formal review workflow and reporting guidance.
.github/agents/repo-consistency.agent.md Updates workflow and .agent-logs/ reporting guidance.
.cspell.yaml Adds words and excludes .agent-logs/ from spell checking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants