Create CleanLabelIndexTask #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…label-compressed/clean-index-task
This task is designed to cleanup the labels_index of reports. As they are carried forward, and tests are renamed, some indexes will point to labels that are not used anymore. This will cause the index to grow indefinetely and the lower indexes will eventually not be used anymore. THe task will scan a report and make sure all indexes are being used, by modifying both the labels_index and the labels in the report.
…label-compressed/clean-index-task
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
========================================
Coverage 98.36% 98.36%
========================================
Files 356 358 +2
Lines 28537 28828 +291
========================================
+ Hits 28069 28357 +288
- Misses 468 471 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
========================================
Coverage 98.32% 98.33%
========================================
Files 387 389 +2
Lines 29232 29524 +292
========================================
+ Hits 28743 29032 +289
- Misses 489 492 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
force-pushed
the
gio/label-compressed/report-with-label-index
branch
from
da2a563
to
ec947a4
Compare
Base automatically changed from
gio/label-compressed/report-with-label-index
to
main
December 6, 2023 14:32
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
========================================
Coverage 98.36% 98.36%
========================================
Files 356 358 +2
Lines 28537 28828 +291
========================================
+ Hits 28069 28357 +288
- Misses 468 471 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
added a commit
that referenced
this pull request
Dec 8, 2023
If the processed upload includes a flag that is carryforward AND "labels" mode, we enqueue the CleanLabelsIndexTask. Depends on #205 I tried to be conservative, but it's possible that - despite using the flag with labels - no labels are uploaded. It's also possible that there's nothing to do. But these are small details. ps.: To see that indeed we have an "arguments" and "flag" in "processing_results" I looked at logs for the message "Scheduling notify task" 😉 closes codecov/engineering-team#768
scott-codecov
approved these changes
Dec 11, 2023
giovanni-guidini
added a commit
that referenced
this pull request
Dec 11, 2023
If the processed upload includes a flag that is carryforward AND "labels" mode, we enqueue the CleanLabelsIndexTask. Depends on #205 I tried to be conservative, but it's possible that - despite using the flag with labels - no labels are uploaded. It's also possible that there's nothing to do. But these are small details. ps.: To see that indeed we have an "arguments" and "flag" in "processing_results" I looked at logs for the message "Scheduling notify task" 😉 closes codecov/engineering-team#768
scott-codecov
added a commit
that referenced
this pull request
Dec 12, 2023
giovanni-guidini
added a commit
that referenced
this pull request
Dec 13, 2023
If the processed upload includes a flag that is carryforward AND "labels" mode, we enqueue the CleanLabelsIndexTask. Depends on #205 I tried to be conservative, but it's possible that - despite using the flag with labels - no labels are uploaded. It's also possible that there's nothing to do. But these are small details. ps.: To see that indeed we have an "arguments" and "flag" in "processing_results" I looked at logs for the message "Scheduling notify task" 😉 Thanks @matt-codecov for the suggestions around refactoring the trigger logic for CleanLabelsIndex to make it easier to read and maintain. closes codecov/engineering-team#768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task is designed to cleanup the labels_index of reports.
As they are carried forward, and tests are renamed, some indexes
will point to labels that are not used anymore. This will cause
the index to grow indefinetely and the lower indexes will eventually
not be used anymore.
These change don't schedule the task, only create it.