fix: check if labels before popping #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A little bug was introduced in label-analysis as part of the label encoding changes: to test if labels are encoded we pop one to see if it's encoded or not. In cases where the report has no labels this raises an exception. These changes first see if there are labels before popping one. Closes codecov/engineering-team#903
giovanni-guidini
requested review from
joseph-sentry,
matt-codecov,
scott-codecov and
adrian-codecov
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 356 356
Lines 28525 28537 +12
=======================================
+ Hits 28057 28069 +12
Misses 468 468
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 356 356
Lines 28525 28537 +12
=======================================
+ Hits 28057 28069 +12
Misses 468 468
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 387 387
Lines 29220 29232 +12
=======================================
+ Hits 28731 28743 +12
Misses 489 489
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bug was introduced in label-analysis as part of the label
encoding changes: to test if labels are encoded we pop one to see
if it's encoded or not.
In cases where the report has no labels this raises an exception.
These changes first see if there are labels before popping one.
Closes codecov/engineering-team#903