feat: call CleanLabelsIndexTask #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 358 358
Lines 28831 28869 +38
=======================================
+ Hits 28351 28389 +38
Misses 480 480
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 358 358
Lines 28831 28869 +38
=======================================
+ Hits 28351 28389 +38
Misses 480 480
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 389 389
Lines 29527 29565 +38
=======================================
+ Hits 29026 29064 +38
Misses 501 501
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Base automatically changed from
gio/label-compressed/clean-index-task
to
main
December 11, 2023 17:45
If the processed upload includes a flag that is carryforward AND "labels" mode, we enqueue the CleanLabelsIndexTask. Depends on #205 I tried to be conservative, but it's possible that - despite using the flag with labels - no labels are uploaded. It's also possible that there's nothing to do. But these are small details. ps.: To see that indeed we have an "arguments" and "flag" in "processing_results" I looked at logs for the message "Scheduling notify task" 😉 closes codecov/engineering-team#768
giovanni-guidini
force-pushed
the
gio/label-compressed/trigger-clean-labels-task
branch
from
a1e8502
to
33d0496
Compare
matt-codecov
approved these changes
Dec 12, 2023
Addressing review comment applying suggested patch. Refactors the trigger logic for CleanLabelsIndex to make it easier to read and maintain. Thanks @matt-codecov
giovanni-guidini
deleted the
gio/label-compressed/trigger-clean-labels-task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the processed upload includes a flag that is carryforward
AND "labels" mode, we enqueue the CleanLabelsIndexTask.
Depends on #205
I tried to be conservative, but it's possible that - despite
using the flag with labels - no labels are uploaded. It's
also possible that there's nothing to do. But these are small
details.
ps.: To see that indeed we have an "arguments" and "flag" in
"processing_results" I looked at logs for the message
"Scheduling notify task" 😉
closes codecov/engineering-team#768
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.