Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for some path fixes for each raw upload processing #135

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

joseph-sentry
Copy link
Contributor

@codecov-staging
Copy link

codecov-staging bot commented Oct 4, 2023

Codecov Report

Merging #135 (8380d91) into main (908dc15) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         348      348           
  Lines       27572    27575    +3     
=======================================
+ Hits        27128    27131    +3     
  Misses        444      444           
Flag Coverage Δ
integration 98.38% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.38% <100.00%> (+<0.01%) ⬆️
unit 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.89% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.17% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/raw_upload_processor.py 97.54% <100.00%> (+0.06%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Oct 4, 2023

Codecov Report

Merging #135 (b320b2c) into main (ebb76ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         358      358           
  Lines       28828    28831    +3     
=======================================
+ Hits        28357    28360    +3     
  Misses        471      471           
Flag Coverage Δ
integration 98.36% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.36% <100.00%> (+<0.01%) ⬆️
unit 98.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.79% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.14% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/raw_upload_processor.py 94.65% <100.00%> (+0.08%) ⬆️

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #135 (b320b2c) into main (ebb76ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         389      389           
  Lines       29523    29527    +4     
=======================================
+ Hits        29031    29035    +4     
  Misses        492      492           
Flag Coverage Δ
integration 98.36% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.36% <100.00%> (+<0.01%) ⬆️
onlysomelabels 98.32% <100.00%> (ø)
unit 98.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.68% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.14% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/raw_upload_processor.py 94.65% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

This change has been scanned for critical changes. Learn more

@joseph-sentry joseph-sentry marked this pull request as ready for review October 4, 2023 18:25
@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 5, 2023

Codecov Report

Merging #135 (b320b2c) into main (ebb76ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         358      358           
  Lines       28828    28831    +3     
=======================================
+ Hits        28357    28360    +3     
  Misses        471      471           
Flag Coverage Δ
integration 98.36% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.36% <100.00%> (+<0.01%) ⬆️
unit 98.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.79% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.14% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/raw_upload_processor.py 94.65% <100.00%> (+0.08%) ⬆️

Copy link
Contributor

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the fixes be in extra instead of the message itself? and what is the point of sampling? we just want to make sure that some are happening?

@joseph-sentry joseph-sentry force-pushed the joseph/log-path-fixes branch 3 times, most recently from f3bed4e to 8b5793b Compare October 18, 2023 13:07
@joseph-sentry joseph-sentry force-pushed the joseph/log-path-fixes branch 2 times, most recently from 7aca960 to 3ef4ba4 Compare December 8, 2023 22:32
@joseph-sentry joseph-sentry merged commit ee0621c into main Dec 12, 2023
26 checks passed
@joseph-sentry joseph-sentry deleted the joseph/log-path-fixes branch December 12, 2023 16:22
scott-codecov added a commit that referenced this pull request Dec 12, 2023
* main:
  Change default upper section from "header" to "condensed_header" (#209)
  Add logs for some path fixes for each raw upload processing (#135)
  Create CleanLabelIndexTask (#205)
  fix: check if labels before popping (#208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs emitted for path fixes
2 participants