Change default upper section from "header" to "condensed_header" #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 98.36% 98.33% -0.04%
==========================================
Files 358 358
Lines 28831 28831
==========================================
- Hits 28360 28351 -9
- Misses 471 480 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 98.36% 98.33% -0.04%
==========================================
Files 358 358
Lines 28831 28831
==========================================
- Hits 28360 28351 -9
- Misses 471 480 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 98.32% 98.30% -0.03%
==========================================
Files 389 389
Lines 29527 29527
==========================================
- Hits 29033 29026 -7
- Misses 494 501 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes
|
joseph-sentry
force-pushed
the
joseph/newheader-default
branch
from
3f863fb
to
e756de2
Compare
giovanni-guidini
approved these changes
Dec 11, 2023
| @@ -209,7 +209,7 @@ def get_upper_section_names(self, settings): | |||
| sections = list(map(lambda l: l.strip(), (settings["layout"] or "").split(","))) | |||
| headers = ["newheader", "header", "condensed_header"] | |||
| if all(not x in sections for x in headers): | |||
| sections.insert(0, "header") | |||
| sections.insert(0, "newheader") | |||
There was a problem hiding this comment.
"condensed_header" is the new name for "newheader" given that "newheader" will not be "new" if it's the default.
NIT comment being use "condensed_header" as the value, not "newheader"
joseph-sentry
force-pushed
the
joseph/newheader-default
branch
from
2e4d4e4
to
e449c0f
Compare
joseph-sentry
changed the title
joseph-sentry
force-pushed
the
joseph/newheader-default
branch
from
e449c0f
to
5779656
Compare
scott-codecov
added a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.