feat: extend ConnitNotification #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes extend the `CommitNotification` model to include an optional field: the github app that emitted a check / comment. ticket: codecov/engineering-team#1737
giovanni-guidini
force-pushed
the
gio/extend-commit-notification
branch
from
c940d68
to
8355053
Compare
Up to this point we didn't pass the GithubAppInstallation ID to the Torngit adapter. This was in part because the info was not needed, and in part because `Owner.integration_id` doesn't have an ID. It would be useful to have this info now, though. As it will allow us to pin down an app to a specific app installation more easily.
RulaKhaled
pushed a commit
that referenced
this pull request
May 27, 2024
* feat: extend ConnitNotification These changes extend the `CommitNotification` model to include an optional field: the github app that emitted a check / comment. ticket: codecov/engineering-team#1737 * improve README with instructions on how to run migrations * chore: include instance ID in GithubInstallationInfo Up to this point we didn't pass the GithubAppInstallation ID to the Torngit adapter. This was in part because the info was not needed, and in part because `Owner.integration_id` doesn't have an ID. It would be useful to have this info now, though. As it will allow us to pin down an app to a specific app installation more easily.
giovanni-guidini
added a commit
that referenced
this pull request
Jun 7, 2024
I broke the GH fallback system again 😅 Fixes this issue: https://l.codecov.dev/dEsZeK The problem is that since #225 (technically codecov/worker#470 actually) we include 1 extra piece of information in `GitHubAppInstallationInfo`, the `GitHubAppInstallation.id`. This is breaking the function that gets tokens because we are destructuring the info dict into the kwargs for the function (with the extra, unexpected `id` one). To fix that we just pop it before calling the function.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
I broke the GH fallback system again 😅 Fixes this issue: https://l.codecov.dev/dEsZeK The problem is that since #225 (technically codecov/worker#470 actually) we include 1 extra piece of information in `GitHubAppInstallationInfo`, the `GitHubAppInstallation.id`. This is breaking the function that gets tokens because we are destructuring the info dict into the kwargs for the function (with the extra, unexpected `id` one). To fix that we just pop it before calling the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes extend the
CommitNotificationmodel to include an optionalfield: the github app that emitted a check / comment.
ticket: codecov/engineering-team#1737
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.