-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: extend ConnitNotification (#225)
* feat: extend ConnitNotification These changes extend the `CommitNotification` model to include an optional field: the github app that emitted a check / comment. ticket: codecov/engineering-team#1737 * improve README with instructions on how to run migrations * chore: include instance ID in GithubInstallationInfo Up to this point we didn't pass the GithubAppInstallation ID to the Torngit adapter. This was in part because the info was not needed, and in part because `Owner.integration_id` doesn't have an ID. It would be useful to have this info now, though. As it will allow us to pin down an app to a specific app installation more easily.
- Loading branch information
1 parent
4b51e8a
commit 7a7847a
Showing
4 changed files
with
86 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
shared/django_apps/core/migrations/0050_commitnotification_gh_app_and_more.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# Generated by Django 4.2.13 on 2024-05-21 19:33 | ||
|
||
import django.db.models.deletion | ||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
dependencies = [ | ||
("codecov_auth", "0055_session_login_session"), | ||
("core", "0049_increment_version"), | ||
] | ||
|
||
# BEGIN; | ||
# -- | ||
# -- Add field gh_app to commitnotification | ||
# -- | ||
# ALTER TABLE "commit_notifications" ADD COLUMN "gh_app_id" bigint NULL CONSTRAINT "commit_notifications_gh_app_id_8714fedd_fk_codecov_a" REFERENCES "codecov_auth_githubappinstallation"("id") DEFERRABLE INITIALLY DEFERRED; SET CONSTRAINTS "commit_notifications_gh_app_id_8714fedd_fk_codecov_a" IMMEDIATE; | ||
# -- | ||
# -- Alter field notification_type on commitnotification | ||
# -- | ||
# -- (no-op) | ||
# CREATE INDEX "commit_notifications_gh_app_id_8714fedd" ON "commit_notifications" ("gh_app_id"); | ||
# COMMIT; | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name="commitnotification", | ||
name="gh_app", | ||
field=models.ForeignKey( | ||
null=True, | ||
on_delete=django.db.models.deletion.CASCADE, | ||
related_name="commit_notifications", | ||
to="codecov_auth.githubappinstallation", | ||
), | ||
), | ||
migrations.AlterField( | ||
model_name="commitnotification", | ||
name="notification_type", | ||
field=models.TextField( | ||
choices=[ | ||
("comment", "Comment"), | ||
("gitter", "Gitter"), | ||
("hipchat", "Hipchat"), | ||
("irc", "Irc"), | ||
("slack", "Slack"), | ||
("status_changes", "Status Changes"), | ||
("status_patch", "Status Patch"), | ||
("status_project", "Status Project"), | ||
("webhook", "Webhook"), | ||
("codecov_slack_app", "Codecov Slack App"), | ||
("checks_project", "Checks Project"), | ||
("checks_changes", "Checks Changes"), | ||
("checks_patch", "Checks Patch"), | ||
] | ||
), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters