Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend ConnitNotification #225

Merged
merged 3 commits into from
May 27, 2024
Merged

feat: extend ConnitNotification #225

merged 3 commits into from
May 27, 2024

Commits on May 22, 2024

  1. feat: extend ConnitNotification 

    These changes extend the `CommitNotification` model to include an optional
field: the github app that emitted a check / comment.

ticket: codecov/engineering-team#1737
    @giovanni-guidini
    giovanni-guidini committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8355053 View commit details
    Browse the repository at this point in the history

  2. improve README with instructions on how to run migrations

    @giovanni-guidini
    giovanni-guidini committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ae7ec45 View commit details
    Browse the repository at this point in the history

  3. chore: include instance ID in GithubInstallationInfo 

    Up to this point we didn't pass the GithubAppInstallation ID to
the Torngit adapter. This was in part because the info was not needed,
and in part because `Owner.integration_id` doesn't have an ID.

It would be useful to have this info now, though. As it will allow
us to pin down an app to a specific app installation more easily.
    @giovanni-guidini
    giovanni-guidini committed May 22, 2024
    Configuration menu
    Copy the full SHA
    92ad210 View commit details
    Browse the repository at this point in the history