feat: add function to get specific app's details #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
force-pushed
the
gio/pin-commits/get-exact-app-info
branch
from
56c2677
to
8386477
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 412 +1
Lines 34153 34187 +34
=======================================
+ Hits 33218 33252 +34
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 412 +1
Lines 34153 34187 +34
=======================================
+ Hits 33218 33252 +34
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 412 +1
Lines 34153 34187 +34
=======================================
+ Hits 33218 33252 +34
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 442 443 +1
Lines 34882 34916 +34
=======================================
+ Hits 33938 33972 +34
Misses 944 944
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Adds `get_specific_github_app_details` function to bots service. This allows us to get `GithubInstallationInfo` for the app we want. It fails with a new exception if the app can't be found. This is because this feature will be used to get the app that made a comment or status check. If we don't use the same to edit said comment it won't work. On top of that we need to start saving the ID of the apps we selected for Torngit adapter instances
giovanni-guidini
force-pushed
the
gio/pin-commits/get-exact-app-info
branch
from
8386477
to
6b8670d
Compare
nora-codecov
approved these changes
May 30, 2024
giovanni-guidini
added a commit
to codecov/shared
that referenced
this pull request
Jun 7, 2024
I broke the GH fallback system again 😅 Fixes this issue: https://l.codecov.dev/dEsZeK The problem is that since #225 (technically codecov/worker#470 actually) we include 1 extra piece of information in `GitHubAppInstallationInfo`, the `GitHubAppInstallation.id`. This is breaking the function that gets tokens because we are destructuring the info dict into the kwargs for the function (with the extra, unexpected `id` one). To fix that we just pop it before calling the function.
github-merge-queue bot
pushed a commit
to codecov/shared
that referenced
this pull request
Jun 10, 2024
I broke the GH fallback system again 😅 Fixes this issue: https://l.codecov.dev/dEsZeK The problem is that since #225 (technically codecov/worker#470 actually) we include 1 extra piece of information in `GitHubAppInstallationInfo`, the `GitHubAppInstallation.id`. This is breaking the function that gets tokens because we are destructuring the info dict into the kwargs for the function (with the extra, unexpected `id` one). To fix that we just pop it before calling the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
get_specific_github_app_detailsfunction to bots service.This allows us to get
GithubInstallationInfofor the app we want.It fails with a new exception if the app can't be found.
This is because this feature will be used to get the app that made a comment
or status check. If we don't use the same app to edit said comment it won't work.
On top of that we need to start saving the ID of the apps we selected for Torngit adapter instances
👀 This commit is part 2/4 of a bigger change that is actually done, but I decided to break it up into multiple PRs so it's easier to review. See how it plays with the rest here: main...gio/pin-commit-to-ghapp
(I'll try to leave the original branch up to date best as I can)