Add ability to pin a GH app to a given commit for notifications #1737
Comments
|
The current idea is to cache the app in Redis. This has some benefits as it's fast to access and shared among the different worker nodes. The thing is that we problem should treat Redis as a permanent store and give the keys some expiry date. This could be very long, but that might not be ideal. Maybe 15 days is enough time for most cases. This believes in a certain amount of "time locality" in commit notifications that is quite reasonable. However there are many commits in a Codecov instance over 15 days. We need to make sure that we can hold this much extra data in the instance. As a "permanent" solution to go with the Redis one we can possibly extend the There's yet another alternative that is to query github directly. Their API returns the app used to send a check (not status) OR comment. |
These changes extend the `CommitNotification` model to include an optional field: the github app that emitted a check / comment. ticket: codecov/engineering-team#1737
These changes extend the `CommitNotification` model to include an optional field: the github app that emitted a check / comment. ticket: codecov/engineering-team#1737
* feat: extend ConnitNotification These changes extend the `CommitNotification` model to include an optional field: the github app that emitted a check / comment. ticket: codecov/engineering-team#1737 * improve README with instructions on how to run migrations * chore: include instance ID in GithubInstallationInfo Up to this point we didn't pass the GithubAppInstallation ID to the Torngit adapter. This was in part because the info was not needed, and in part because `Owner.integration_id` doesn't have an ID. It would be useful to have this info now, though. As it will allow us to pin down an app to a specific app installation more easily.
* feat: extend ConnitNotification These changes extend the `CommitNotification` model to include an optional field: the github app that emitted a check / comment. ticket: codecov/engineering-team#1737 * improve README with instructions on how to run migrations * chore: include instance ID in GithubInstallationInfo Up to this point we didn't pass the GithubAppInstallation ID to the Torngit adapter. This was in part because the info was not needed, and in part because `Owner.integration_id` doesn't have an ID. It would be useful to have this info now, though. As it will allow us to pin down an app to a specific app installation more easily.
When a comment/check is made by a specific GH app on a commit, cache which app was used. Use this app on subsequent requests if possible.
The text was updated successfully, but these errors were encountered: