kvpb,kvserver: add range id, span to BatchTimestampBeforeGCError #131545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Remove regular expressions, where simple string comparisons will suffice. Release note: None.
nicktrav
force-pushed
the
nickt.errors-range
branch
from
40fff3a to
7b2b54f
Compare
nicktrav
requested review from
andyyang890 and
arulajmani
and removed request for
a team
andyyang890
reviewed
Sep 30, 2024
Collaborator
andyyang890
left a comment
andyyang890
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @nicktrav)
-- commits line 10 at r2:
nit: s/kvp/kvpb/
stevendanna
approved these changes
Sep 30, 2024
Collaborator
stevendanna
left a comment
stevendanna
left a comment
There was a problem hiding this comment.
This would have been super helpful in a number of places.
Currently, debugging a `BatchTimestampBeforeGCError` is difficult, as there information is lacking as to replica / range tried to touch underneath the GC threshold. Add the range ID and span to the error message. Fixes cockroachdb#131256. Release note: None.
nicktrav
force-pushed
the
nickt.errors-range
branch
from
7b2b54f to
96b93e8
Compare
Collaborator
Author
|
TFTRs! bors r+ |
Contributor
andyyang890
changed the title
Collaborator
|
blathers backport 24.2 24.1 23.2 |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #131256: branch-release-23.2, branch-release-24.1, branch-release-24.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 96b93e8 to blathers/backport-release-23.2-131545: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
nicktrav
added a commit
to nicktrav/cockroach
that referenced
this pull request
Sep 2, 2025
Fix a testing bug introduced in cockroachdb#131545 where the `Contains` check arguments were reversed. The error string to being searched should precede the string being searched for. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None
nicktrav
added a commit
to nicktrav/cockroach
that referenced
this pull request
Sep 2, 2025
Fix a testing bug introduced in cockroachdb#131545 where the `Contains` check arguments were reversed. The error string being _searched_ should precede the string being _searched for_. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
152880: changefeedccl: fix reversed args for containment check in test logic r=nicktrav a=nicktrav Fix a testing bug introduced in #131545 where the `Contains` check arguments were reversed. The error string being _searched_ should precede the string being _searched for_. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None Epic: None Co-authored-by: Nick Travers <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
Fix a testing bug introduced in #131545 where the `Contains` check arguments were reversed. The error string being _searched_ should precede the string being _searched for_. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None
blathers-crl bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
Fix a testing bug introduced in #131545 where the `Contains` check arguments were reversed. The error string being _searched_ should precede the string being _searched for_. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None
blathers-crl bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
Fix a testing bug introduced in #131545 where the `Contains` check arguments were reversed. The error string being _searched_ should precede the string being _searched for_. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None
blathers-crl bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
Fix a testing bug introduced in #131545 where the `Contains` check arguments were reversed. The error string being _searched_ should precede the string being _searched for_. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, debugging a
BatchTimestampBeforeGCErroris difficult, as there information is lacking as to replica / range tried to touch underneath the GC threshold.Add the range ID and span to the error message.
Fixes #131256.
Release note: None.