-
Notifications
You must be signed in to change notification settings - Fork 4k
release-24.1: changefeedccl: fix reversed args for containment check in test logic #153208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix a testing bug introduced in #131545 where the `Contains` check arguments were reversed. The error string being _searched_ should precede the string being _searched for_. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None
55421eb to
ffe0645
Compare
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
|
✅ PR #153208 is compliant with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
TFTR! |
Backport 1/1 commits from #152880 on behalf of @nicktrav.
Fix a testing bug introduced in #131545 where the
Containscheck arguments were reversed. The error string being searched should precede the string being searched for. The examples from the API docs:Release note: None
Epic: None
Release justification: Test only.