Skip to content

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Nov 4, 2024

Backport 2/2 commits from #131545 on behalf of @nicktrav.

/cc @cockroachdb/release


Currently, debugging a BatchTimestampBeforeGCError is difficult, as there information is lacking as to replica / range tried to touch underneath the GC threshold.

Add the range ID and span to the error message.

Fixes #131256.

Release note: None.


Release justification:

Remove regular expressions, where simple string comparisons will
suffice.

Release note: None.
Currently, debugging a `BatchTimestampBeforeGCError` is difficult, as
there information is lacking as to replica / range tried to touch
underneath the GC threshold.

Add the range ID and span to the error message.

Fixes #131256.

Release note: None.
@blathers-crl blathers-crl bot requested review from a team as code owners November 4, 2024 22:17
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-131545 branch from af1606b to 47deb11 Compare November 4, 2024 22:17
@blathers-crl blathers-crl bot requested review from andyyang890 and removed request for a team November 4, 2024 22:17
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 4, 2024
@blathers-crl
Copy link
Author

blathers-crl bot commented Nov 4, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 4, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@arulajmani arulajmani merged commit e707ed2 into release-24.1 Nov 5, 2024
18 of 20 checks passed
@arulajmani arulajmani deleted the blathers/backport-release-24.1-131545 branch November 5, 2024 23:20
@crl-codesys-jira crl-codesys-jira added the T-kv KV Team label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-kv KV Team v24.1.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants