release-25.3: changefeedccl: fix reversed args for containment check in test logic #153211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a testing bug introduced in #131545 where the `Contains` check arguments were reversed. The error string being _searched_ should precede the string being _searched for_. The examples from the API docs: ``` // require.Contains(t, "Hello World", "World") // require.Contains(t, ["Hello", "World"], "World") // require.Contains(t, {"Hello": "World"}, "Hello") ``` Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-25.3-152880
branch
from
9ae6f1f to
1c2806f
Compare
blathers-crl
bot
requested review from
log-head
and removed request for
a team
blathers-crl
bot
added
blathers-backport
Author
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
the
backport
Member
|
This change is |
blathers-crl
bot
added
the
backport-test-only
aerfrei
approved these changes
Sep 10, 2025
Collaborator
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #152880 on behalf of @nicktrav.
Fix a testing bug introduced in #131545 where the
Containscheck arguments were reversed. The error string being searched should precede the string being searched for. The examples from the API docs:Release note: None
Epic: None
Release justification: Test only.