-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: use connect_pass_through flag instead of workaround for TCP regression #9506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 21f899f The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude forgot a changeset
|
The deleted test ( |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
This reverts commit d033a7d.
…orker Add the connect_pass_through compatibility flag to the outbound service worker that strips CF-Connecting-IP headers. This resolves the TCP connection regression that was introduced when using globalOutbound service with workerd's connect() API. The connect_pass_through flag was added in workerd PR #4171 to fix the underlying issue, allowing us to remove the JavaScript injection workaround and use the cleaner global outbound approach. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…geset - Add 'experimental' compat flag alongside 'connect_pass_through' - Add changeset for the TCP regression fix - The deleted test was specific to the workaround we're replacing
cb612f0 to
21f899f
Compare
Fixes #9238.
This PR reverts the workaround from #9246 and implements the proper fix for the TCP connection regression by adding the
connect_pass_throughcompatibility flag to the globalOutbound worker.Background
CF-Connecting-IPheadersconnect()API andglobalOutboundsetting caused TCP ingress failures (issue Regression with TCP connections in 4.15.0 #9238)connect_pass_throughcompatibility flagChanges
git revert d033a7da1to cleanly remove Edmund's temporary fixcompatibilityFlags: ["connect_pass_through"]in the outbound service worker configuration inpackages/miniflare/src/plugins/core/index.ts:840Impact
🤖 Generated with Claude Code