fix: strips CF-Connecting-IP header within Wrangler #9246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 59790ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-wrangler-9246Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-workers-bindings-extension-9246 -O ./cloudflare-workers-bindings-extension.0.0.0-v5c9a16f70.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5c9a16f70.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-create-cloudflare-9246 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-kv-asset-handler-9246
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-miniflare-9246
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-pages-shared-9246
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-unenv-preset-9246
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-vite-plugin-9246
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-vitest-pool-workers-9246
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-workers-editor-shared-9246
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-workers-shared-9246
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15029420754/npm-package-cloudflare-workflows-shared-9246Note that these links will no longer work once the GitHub Actions artifact expires. |
edmundhung
force-pushed
the
edmundhung/cf-connecting-ip-followup
branch
2 times, most recently
from
9c85a63 to
5376026
Compare
edmundhung
force-pushed
the
edmundhung/cf-connecting-ip-followup
branch
from
536ec34 to
59790ee
Compare
Contributor
|
These changes have been automatically backported to Wrangler v3 🎉 You can view the automatically updated PR at v3-maintenance...v3-maintenance-9246. Please check that PR for correctness, and make sure it's merged after this one. Thank you for helping us keep Wrangler v3 supported! |
petebacondarwin
approved these changes
May 14, 2025
Merged
edmundhung
added a commit
that referenced
this pull request
May 16, 2025
…ler (#9250) * fix(miniflare): disable stripCfConnectingIp option by default * add a regression test from the wrangler persepective * inject monkey patched fetch to strip header * add changeset --------- Co-authored-by: Edmund Hung <[email protected]>
12 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
This reverts commit d033a7d.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
…ession (#9506) * Revert "fix: strips CF-Connecting-IP header within Wrangler (#9246)" This reverts commit d033a7d. * feat: add connect_pass_through compatibility flag to globalOutbound worker Add the connect_pass_through compatibility flag to the outbound service worker that strips CF-Connecting-IP headers. This resolves the TCP connection regression that was introduced when using globalOutbound service with workerd's connect() API. The connect_pass_through flag was added in workerd PR #4171 to fix the underlying issue, allowing us to remove the JavaScript injection workaround and use the cleaner global outbound approach. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * fix: add connect_pass_through and experimental compat flags, add changeset - Add 'experimental' compat flag alongside 'connect_pass_through' - Add changeset for the TCP regression fix - The deleted test was specific to the workaround we're replacing * human fixups * fix lockfile * fix lockfile * fix lockfile --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9238.