Skip to content

Conversation

@penalosa
Copy link
Contributor

Backport changes from #9506


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: only affects Miniflare internal worker configuration
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal implementation change, no user-facing API changes

penalosa and others added 4 commits June 6, 2025 16:11
…orker

Add the connect_pass_through compatibility flag to the outbound service worker
that strips CF-Connecting-IP headers. This resolves the TCP connection regression
that was introduced when using globalOutbound service with workerd's connect() API.

The connect_pass_through flag was added in workerd PR #4171 to fix the underlying
issue, allowing us to remove the JavaScript injection workaround and use the
cleaner global outbound approach.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
…geset

- Add 'experimental' compat flag alongside 'connect_pass_through'
- Add changeset for the TCP regression fix
- The deleted test was specific to the workaround we're replacing
@penalosa penalosa requested a review from a team as a code owner June 16, 2025 14:45
@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: 7241139

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
miniflare Patch
wrangler Patch
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 16, 2025
@penalosa penalosa added the v3-backport The PR is a v3 backport targetting the v3-maintenance branch label Jun 16, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 16, 2025
@penalosa
Copy link
Contributor Author

I'm going to close this, because:

  1. This is a refactor, not a fix (i.e. CF-Connecting-IP is stripped via Wrangler in v3 today
  2. Backporting will require bumping workerd in v3, which is a can of worms that may require a bunch of other changes

cc @lrapoport-cf for visibility

@penalosa penalosa closed this Jun 16, 2025
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3-backport The PR is a v3 backport targetting the v3-maintenance branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants