Allow Angular 5 #40
Merged
Allow Angular 5 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At first I didn't think about closing the issue, so I've created branch under different name. |
f1ames
suggested changes
Jul 12, 2019
There was a problem hiding this comment.
Could you also update README on Angular versions compatibility (you make take a look how CKE5 does this)?
|
I copied section from CKE5 README, our case is identical, so I don't think it is necessary to reword it in any way. |
|
When the new releasw will be in npm repository? |
|
@Sakamotto next week, between 19-21.11. It will be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied change required to work with Angular 5, see #39 (comment)
Also changed all leftover
Angular 2+references so that version isn't mentioned.Closes #39. Closes #37. Closes #42.