Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ElementRef is not generic #37

Closed
ghost opened this issue Jun 17, 2019 · 2 comments · Fixed by #40
Closed

[BUG] ElementRef is not generic #37

ghost opened this issue Jun 17, 2019 · 2 comments · Fixed by #40

Comments

@ghost
Copy link

ghost commented Jun 17, 2019

Reproduction steps

  1. $ npm install
  2. $ ng serve

Expected result

The application compiles.

Actual result

An error is thrown during compilation:

ERROR in node_modules/ckeditor4-angular/ckeditor.component.d.ts(113,29): error TS2315: Type 'ElementRef' is not generic.

Can be 'fixed' with

node_modules/ckeditor4-angular/ckeditor.component.d.ts(113,29):

-- constructor(elementRef: ElementRef<HTMLElement>, ngZone: NgZone);
++ constructor(elementRef, ngZone: NgZone);

Other details

  • Browser: any
  • OS: MacOS / Linux (and probably Windows)
  • CKEditor version: 1.0.0-beta
  • Installed CKEditor plugins: none
  • Angular version: 5.2.11
@ghost ghost changed the title ElementRef is not generic [BUG] ElementRef is not generic Jun 17, 2019
@f1ames
Copy link
Contributor

f1ames commented Jul 12, 2019

This will be fixed with #40.

@engineering-this engineering-this mentioned this issue Jul 12, 2019
Merged
@ghost
Copy link
Author

ghost commented Jul 19, 2019

Thank you!

@ghost ghost closed this as completed Jul 19, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Angular 5 ckeditor/ckeditor4-angular
1 participant
@f1ames