Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Angular 5 #40

Merged
merged 4 commits into from
Aug 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ See the [CKEditor 4 Angular Integration](https://ckeditor.com/docs/ckeditor4/lat

The CKEditor 4 Angular component works with all the [supported browsers](https://ckeditor.com/docs/ckeditor4/latest/guide/dev_browsers.html#officially-supported-browsers) except for Internet Explorer 8-10.

## Supported Angular versions

The integration can be used together with Angular at version 5.0.0 and higher. It is an implication of Angular metadata produced for this package by the Angular builder. Note that the package.json used in the main repository isn't published on NPM (the production one is present in `src/ckeditor/package.json`), so there are only a few peer dependencies to `@angular/core` >= 5.0.0, `@angular/common` >= 5.0.0 and `@angular/forms` >= 5.0.0 required by this package.

## Contributing

Here is how you can contribute to the development of the component. Any feedback and help will be most appreciated!
Expand Down
2 changes: 1 addition & 1 deletion e2e/src/app.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe( 'workspace-project App', () => {
} );

it( 'should display welcome message', () => {
expect( page.getParagraphText() ).toEqual( 'CKEditor integration with Angular 2+' );
expect( page.getParagraphText() ).toEqual( 'CKEditor integration with Angular' );
} );

it( 'should display editor with initial content', async () => {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ckeditor4-angular",
"version": "1.0.0",
"description": "Official Angular 2+ component for CKEditor 4.",
"description": "Official Angular component for CKEditor 4.",
"scripts": {
"ng": "ng",
"start": "ng serve",
Expand Down
2 changes: 1 addition & 1 deletion src/app/app.component.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<h1>CKEditor integration with Angular 2+</h1>
<h1>CKEditor integration with Angular</h1>

<nav>
<ul>
Expand Down
2 changes: 1 addition & 1 deletion src/ckeditor/ckeditor.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export class CKEditorComponent implements AfterViewInit, OnDestroy, ControlValue
*/
@Input() editorUrl = 'https://cdn.ckeditor.com/4.12.1/standard-all/ckeditor.js';

constructor( private elementRef: ElementRef<HTMLElement>, private ngZone: NgZone ) {
constructor( private elementRef: ElementRef, private ngZone: NgZone ) {
}

ngAfterViewInit(): void {
Expand Down
2 changes: 1 addition & 1 deletion src/ckeditor/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ckeditor4-angular",
"version": "0.1.0",
"description": "Official Angular 2+ component for CKEditor 4.",
"description": "Official Angular component for CKEditor 4.",
"keywords": [
"wysiwyg",
"rich text",
Expand Down