Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check backwards compatibility with older Angular version #39

Closed
f1ames opened this issue Jul 3, 2019 · 1 comment · Fixed by #40
Closed

Check backwards compatibility with older Angular version #39

f1ames opened this issue Jul 3, 2019 · 1 comment · Fixed by #40
Assignees
Milestone

Comments

@f1ames
Copy link
Contributor

f1ames commented Jul 3, 2019

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

Since we developed the integration with latest Angular version, it's not clear which older versions are supported. The assumption was it should be Angular 2+, however it was never checked.

The compatibility with older versions should be checked and short section added to readme file (could be similar to what CKE5 have - https://github.com/ckeditor/ckeditor5-angular#supported-angular-versions).

@engineering-this
Copy link
Contributor

Angular 6+

Works fine.

Angular 5

Throws an error, it can be fixed by changing

constructor( private elementRef: ElementRef<HTMLElement>, private ngZone: NgZone ) {

to

constructor( private elementRef: ElementRef, private ngZone: NgZone ) { 

Reason is that elementRef isn't a generic type before Angular 6. However this change doesn't seem to break anything in newer versions. I'll provide PR.

Angular 4

Angular 4 has incompatible package meta-data format, so it won't work without separate package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants