Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Ref is not generic error is thrown in Angular 5 on build #66

Closed
Chinna2405 opened this issue Nov 13, 2019 · 3 comments
Closed

Comments

@Chinna2405
Copy link

Chinna2405 commented Nov 13, 2019

Are you reporting a feature request or a bug?

Provide detailed reproduction steps (if any)

1.On running the ng build command i am getting the below error.
2.ERROR in node_modules/ckeditor4-angular/ckeditor.component.d.ts(113,29): error TS2315: Type 'ElementRef' is not generic.

Expected result

What is the expected result of the above steps?

Actual result

What is the actual result of the above steps?

Other details

  • Browser: …
  • OS: …
  • Integration version: …
  • Angular version: 5.x.x
  • CKEditor version:0.1.0
  • Installed CKEditor plugins: …

Thanks in Advance.

@f1ames
Copy link
Contributor

f1ames commented Nov 13, 2019

Hello @Chinna2405,
this issue was already addressed in #40 PR. The package with the fix will be released next week.

@paolomainardi
Copy link

I am having the same issue, is there any workaround before the new release ?

@f1ames
Copy link
Contributor

f1ames commented Nov 13, 2019

The change needed is quite simple - https://github.com/ckeditor/ckeditor4-angular/pull/40/files#diff-756e5674b9c69ad85fad09a2b0c3e852R194 so you may try apply it manually.

The best bet would be building package from the current master like:

git clone https://github.com/ckeditor/ckeditor4-angular.git
cd ckeditor4-angular
npm run build-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants