-- webtest cleanup (used openCiviPage function in place of open) #4

ravishnair · 2013-03-01T13:10:42Z

Replaced open function with the openCiviPage function.

-- webtest cleanup (used openCiviPage function in place of open)

colemanw · 2013-03-01T19:11:03Z

Note: The waitForPageToLoad() method should not be called after openCiviPage since it will be redundant.
The first line of your patch there is one left in there.

worked on CRM-12096, set component title, that fixes notice in j3

Search

…-12965

VAT-86-94-224 Added validation when 'Is Tax?' is checked. Checked for fi...

Webtests fixes for CRM-15701 fix

Civi 28

alias level as severity for Status paradigm; CRM-13823;

Remove whitespace

CRM-12163

CRM-16313. Do not reject IDN email addresses.

* CRM-20345 - CRM_Utils_Array::crmArraySortByField - Add test. Allow multiple fields. * CRM-20345 - CRM_Utils_SQL_Select::orderBy - Use more deterministic ordering The technique of computing default `$weight = count($this->orderBys)` addresses a valid point: we need to preserve ordering for existing callers who don't specify weights -- while also allowing weights. However, it feels weird in my gut. Not sure why -- maybe it's something like this: ```php // A1: Non-deterministic ordering $select->orderBy('alpha', 1); $select->orderBy('beta'); $select->orderBy('delta', 2); $select->orderBy('gamma', 3); // A2: Deterministic ordering $select->orderBy('alpha', 10); $select->orderBy('beta'); $select->orderBy('delta', 20); $select->orderBy('gamma', 30); // B1: Deterministic ordering $select->orderBy('alpha'); $select->orderBy('beta'); $select->orderBy('delta'); $select->orderBy('gamma'); // B2: Non-deterministic ordering $select->orderBy('alpha', 1); $select->orderBy('beta', 1); $select->orderBy('delta', 1); $select->orderBy('gamma', 1); ``` As a reader, I would expect A1/A2 to be the same, and I would expect B1/B2 to be the same. But they're not. If there's a collision in the `weight`s, the ordering becomes non-deterministic (depending on obscure details or happenstance of the PHP runtime). Of course, there's no right answer: in A1/A2, you can plausibly put `beta` before `alpha` or after `alpha` or after `gamma`. But it should be determinstic so that it always winds up in the same place.

The recent revision #9595 updated `ExternalBatch` to produce a more informative error message. However, in the test environment used by `flexmailer`, there was exactly 1 value in `$_ENV` (even if `variables_order` was misconfigured). This should make the test a bit harder to trip-up by affirmatively checking for the most common environment variable. Review note: In the known universe, the only direct references to `ExternalBatch` are in `CiviUnitTestCase`, so this shouldn't impact any runtime logic.

CRM-20561 - Remove example files. Cleanup code style.

There appears to be some application logic which follows a process like this: 1. Read the case 2. Tweak the data 3. Save updated case The problem is comes if step civicrm#4 resaves a timestamp loaded in step #1, which is fairly likely to happen if you read+save the same record. This was specifically observed on the "Manage Case" screen when editing activities, but the data-flow is pretty common, so make a general fix to the BAO.

Use-case: 1. Open the editor a message template (eg `#/edit?id=17&lang=fr_FR`). This renders the edit screen. 2. Click on the "Preview" icon. 3. Close the "Preview" dialog. 4. Change the URL to navigate internally to another template (eg `#/edit?id=17&lang=de_DE`). This renders the edit screen again. 5. Click on the "Preview" icon. Before: * It subsequently opens two copies of the "Preview" dialog (each with slightly different options). Initially, you see one dialog. When that close, you will see the other dialog. * As you proceed through closing the dialogs, you may get console warnings because the dialogs have the same name -- and they consequently trip-up each other. After: * It only opens one copy of the "Preview" dialog. Technical Details: * When rendering the setup screen (`#1`/`civicrm#4`), it registers a listener which will handle the "Preview" clicks. But the listener is not properly unregistered. Consequently, old listeners hang around. So the click at step `civicrm#5` calls both the old+new listeners, creating two dialogs.

…ion-fix) Overview -------- Fixes a recent regression that prevents you from uninstalling extensions via CLI. This specifically affects extensions which use managed entities. Steps to reproduce ------------------ ``` cv en afform cv dis afform cv ext:uninstall afform ``` Before ------- ``` [bknix-max:~/bknix/build/dmaster/web/sites/all/modules/civicrm] cv en afform && cv dis afform && cv ext:uninstall afform Enabling extension "org.civicrm.afform" Disabling extension "org.civicrm.afform" Uninstalling extension "org.civicrm.afform" Error: API Call Failed: Array ( [entity] => Extension [action] => uninstall [params] => Array ( [keys] => Array ( [0] => org.civicrm.afform ) [debug] => 1 [version] => 3 ) [result] => Array ( [error_code] => unauthorized [entity] => Extension [action] => uninstall [trace] => #0 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(147): Civi\API\Kernel->authorize(Object(Civi\Api4\Provider\ActionObjectProvider), Object(Civi\Api4\Generic\DAODeleteAction)) #1 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAODeleteAction)) #2 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute() civicrm#3 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(467): civicrm_api4('OptionValue', 'delete', Array) civicrm#4 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(303): CRM_Core_ManagedEntities->removeStaleEntity(Object(CRM_Core_DAO_Managed)) civicrm#5 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(134): CRM_Core_ManagedEntities->reconcileUnknownModules() civicrm#6 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(409): CRM_Core_ManagedEntities->reconcile() civicrm#7 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Extension/Manager.php(483): CRM_Core_Invoke::rebuildMenuAndCaches(true) civicrm#8 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/v3/Extension.php(183): CRM_Extension_Manager->uninstall(Array) civicrm#9 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_extension_uninstall(Array) civicrm#10 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(149): Civi\API\Provider\MagicFunctionProvider->invoke(Array) civicrm#11 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest(Array) civicrm#12 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(22): Civi\API\Kernel->runSafe('Extension', 'uninstall', Array) civicrm#13 phar:///home/me/bknix/bin/cv/src/Command/BaseCommand.php(49): civicrm_api('Extension', 'uninstall', Array) civicrm#14 phar:///home/me/bknix/bin/cv/src/Command/ExtensionUninstallCommand.php(63): Civi\Cv\Command\BaseCommand->callApiSuccess(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput), 'Extension', 'uninstall', Array) civicrm#15 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Command/Command.php(257): Civi\Cv\Command\ExtensionUninstallCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#16 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(850): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#17 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRunCommand(Object(Civi\Cv\Command\ExtensionUninstallCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#18 phar:///home/me/bknix/bin/cv/src/Application.php(46): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#19 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(124): Civi\Cv\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#20 phar:///home/me/bknix/bin/cv/src/Application.php(15): Symfony\Component\Console\Application->run() civicrm#21 phar:///home/me/bknix/bin/cv/bin/cv(27): Civi\Cv\Application::main('phar:///Users/t...') civicrm#22 /home/me/bknix/bin/cv(14): require('phar:///Users/t...') civicrm#23 {main} [is_error] => 1 [error_message] => Authorization failed ) ) ``` After ----- Works Comment ------- I encountered this while working on E2E test-coverage for other changes. The E2E test coverage had worked on a previous iteration of 5.45.alpha1 but failed when I rebased. Consequently, this means You can see a prior draft of the E2E test [here](https://github.com/totten/shimmy/blob/master-reorg/shimmy/tests/phpunit/E2E/Shimmy/LifecycleTest.php#L56-L77). However, it's being reworked as a core patch. I'd suggest accepting this without a test - because (a) it's a regression and (b) there will be coverage from the pending change.

CRM_Event_Page_EventInfoTest::testFullMessage Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail" #0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail") #1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail") #2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail") #3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail") #4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3)) #5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59)) #6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules() #7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE) #8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE) #9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus() #10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll() #11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts() #12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()

-- webtest cleanup (used openCiviPage function in place of open)

cb5b38f

kurund added a commit that referenced this pull request Mar 1, 2013

Merge pull request #4 from ravishnair/webtest-fixes

59535ee

-- webtest cleanup (used openCiviPage function in place of open)

kurund merged commit 59535ee into civicrm:master Mar 1, 2013

pratik-joshi mentioned this pull request Mar 14, 2013

CRM-12062 : minor bug found by failing test case WebTest_Event_AddEventTest::testAddPaidEventNoTemplate #145

Merged

MegaphoneJon pushed a commit to MegaphoneJon/civicrm-core that referenced this pull request Apr 30, 2013

Merge pull request civicrm#4 from kurund/CRM-12096

75473c8

worked on CRM-12096, set component title, that fixes notice in j3

colemanw pushed a commit to twomice/civicrm-core that referenced this pull request Apr 30, 2013

Merge pull request civicrm#4 from twomice/search

104c432

Search

ravishnair mentioned this pull request Jun 14, 2013

CRM-12809 #1012

Merged

kurund added a commit to kurund/civicrm-core that referenced this pull request Jul 12, 2013

added formRule to prevent conflict between barcode and civicrm#4, CRM…

890a1fb

…-12965

mmikitka mentioned this pull request Jul 24, 2013

Fix for issue CRM-13089 #1206

Merged

deepak-srivastava mentioned this pull request Dec 23, 2013

CRM-13918 add report_template.getrows, report_template.getstatistics api functions #2170

Merged

rohankatkar pushed a commit to rohankatkar/civicrm-core-master that referenced this pull request May 22, 2014

Merge pull request civicrm#4 from rohankatkar/VAT-86-94-224-New

042cbb6

VAT-86-94-224 Added validation when 'Is Tax?' is checked. Checked for fi...

kurund added a commit that referenced this pull request Dec 23, 2014

Merge pull request #4 from manishmore/CRM-15701-QA-fixes

e89cb8e

Webtests fixes for CRM-15701 fix

eileenmcnaughton referenced this pull request in eileenmcnaughton/civicrm-core Jan 6, 2015

CRM-15680 fix custom data on survey & campaign

bf38705

Edzelopez added a commit to Edzelopez/civicrm-core that referenced this pull request Mar 16, 2015

Merge pull request civicrm#4 from Edzelopez/CIVI-28

5ebc974

Civi 28

MegaphoneJon pushed a commit to MegaphoneJon/civicrm-core that referenced this pull request Apr 26, 2015

Merge pull request civicrm#4 from ginkgostreet/rename_severity

a366dde

alias level as severity for Status paradigm; CRM-13823;

kurund pushed a commit to kurund/civicrm-core that referenced this pull request May 12, 2015

Merge pull request civicrm#4 from eileenmcnaughton/patch-6

b310af8

Remove whitespace

KarinG mentioned this pull request Jul 15, 2016

CRM-19061 Updated Reports from sprint #8539

Closed

KarinG mentioned this pull request Aug 7, 2016

(WIP) Sybunt - Rob's work #8823

Closed

jitendrapurohit mentioned this pull request Sep 2, 2016

CRM 18651 - Add in Option Group and soft validation #8503

Merged

f2boot pushed a commit to f2boot/civicrm-core that referenced this pull request Sep 25, 2016

Merge pull request civicrm#4 from dlobo/CRM-12163

4512c9a

CRM-12163

ErichBSchulz pushed a commit to ErichBSchulz/civicrm-core that referenced this pull request Jan 3, 2017

Merge pull request civicrm#4 from fuzionnz/4.4.15rc1-CRM-16313

4c307a6

CRM-16313. Do not reject IDN email addresses.

davejenx mentioned this pull request Apr 24, 2017

CRM-20441 Fix issue where multiple activity Ids were not supported wh… #10212

Merged

totten pushed a commit that referenced this pull request Jun 16, 2017

Merge pull request #4 from totten/seamuslee001-CRM-20561

37fcf8d

CRM-20561 - Remove example files. Cleanup code style.

eileenmcnaughton mentioned this pull request May 26, 2021

See how many tests fail with this check #20420

Closed

eileenmcnaughton mentioned this pull request Sep 19, 2021

find tests #21534

Closed

eileenmcnaughton mentioned this pull request Oct 4, 2021

flexmailer - Update [CiviMail Draft] prefix to match BAO behavior #21715

Merged

eileenmcnaughton mentioned this pull request Oct 17, 2021

Switch replaceGreetingTokens over #21790

Merged

eileenmcnaughton mentioned this pull request Jan 12, 2022

Fully deprecate getTokenDetails #22483

Merged

This was referenced Feb 24, 2022

get membership type ID and number of terms from price_x fields #22825

Merged

Add handling for civimember disabled #22864

Merged

rashedulislam mentioned this pull request Mar 2, 2022

Call to undefined function civicrm_api3_create_error() in civicrm/civ… #22872

Merged

ginkgomzd mentioned this pull request Apr 26, 2022

correct logic for handling empty-array values for checkboxes; #23305

Merged

eileenmcnaughton mentioned this pull request Sep 26, 2022

Fix import class loading issue in entityTypes hook #24621

Merged

eileenmcnaughton mentioned this pull request Nov 10, 2022

Core extensions - Upgrade to civix 22.10.0 #24944

Merged

eileenmcnaughton mentioned this pull request Nov 23, 2022

EntityFinancialAccount - A tale of two BAO classes #25036

Merged

eileenmcnaughton mentioned this pull request Feb 18, 2023

Fix test method eventCreatePaid for php 8.2 #25613

Closed

eileenmcnaughton mentioned this pull request Feb 28, 2023

BAO - Noisily deprecate and stop using deprecated functions #25677

Merged

eileenmcnaughton mentioned this pull request Jun 2, 2023

Stop passing $ids to membership::create #26373

Merged

eileenmcnaughton mentioned this pull request Jul 27, 2023

[PHP8.2] Remove undeclared property #26947

Merged

eileenmcnaughton mentioned this pull request Aug 23, 2023

dev/core#2644 Add Scheduled Communications extension #27081

Merged

eileenmcnaughton mentioned this pull request Sep 18, 2023

Use some code for offline as online participant for payment section #27486

Closed

eileenmcnaughton mentioned this pull request Oct 11, 2023

Update smarty localize for Smarty3 #27776

Merged

eileenmcnaughton mentioned this pull request Nov 8, 2023

Revisit the default Scheduled Jobs. Adjust the frequency… #28052

Merged

eileenmcnaughton mentioned this pull request Nov 26, 2023

Make financialacls require civi-contribute #28318

Merged

This was referenced Jan 4, 2024

Add system check to warn if CiviReport disabled & logging enabled #28863

Merged

Logging detail test #28869

Closed

eileenmcnaughton mentioned this pull request Feb 8, 2024

Incoming SMS replies are not linked to CiviCRM Contacts #26997

Open

This was referenced Jun 19, 2024

WIP: Fix for https://lab.civicrm.org/dev/core/-/issues/5095 #29736

Closed

Enable message admin by default on new installs #30503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

-- webtest cleanup (used openCiviPage function in place of open) #4

-- webtest cleanup (used openCiviPage function in place of open) #4

ravishnair commented Mar 1, 2013

colemanw commented Mar 1, 2013

-- webtest cleanup (used openCiviPage function in place of open) #4

-- webtest cleanup (used openCiviPage function in place of open) #4

Conversation

ravishnair commented Mar 1, 2013

colemanw commented Mar 1, 2013