Merge pull request civicrm#4 from Edzelopez/CIVI-28

Civi 28

Author: Edzelopez

CRM/Contribute/Form/Contribution.php

@@ -489,6 +489,14 @@ public function setDefaultValues() {
    * Build the form object.
    */
   public function buildQuickForm() {
+    
+    // FIXME: This probably needs to be done in preprocess
+    if ($this->_action & CRM_Core_Action::UPDATE) {
+      $financialTypeID = CRM_Contribute_PseudoConstant::financialType($this->_values['financial_type_id']);
+      if (!CRM_Core_Permission::check('edit contributions of type ' . $financialTypeID)) {
+        CRM_Core_Error::fatal(ts('You do not have permission to access this page.'));
+      }
+    }
     //@todo document the purpose of cdType (if still in use)
     if ($this->_cdType) {
       CRM_Custom_Form_CustomData::buildQuickForm($this);
@@ -641,13 +649,23 @@ public function buildQuickForm() {
     }
 
     $attributes = CRM_Core_DAO::getAttribute('CRM_Contribute_DAO_Contribution');
+    
+    // Check permissions for financial type first
+    $financialTypes = CRM_Contribute_PseudoConstant::financialType();
+    
+    foreach ($financialTypes as $finTypeId => $type) {
+      if (!CRM_Core_Permission::check('add new contributions of type ' . $type)) {
+        unset($financialTypes[$finTypeId]);
+      }
+    }
 
     $financialType = $this->add('select', 'financial_type_id',
       ts('Financial Type'),
-      array('' => ts('- select -')) + CRM_Contribute_PseudoConstant::financialType(),
+      array('' => ts('- select -')) + $financialTypes,
       TRUE,
       array('onChange' => "CRM.buildCustomData( 'Contribution', this.value );")
     );
+
     $paymentInstrument = FALSE;
     if (!$this->_mode) {
       $paymentInstrument = $this->add('select', 'payment_instrument_id',

CRM/Financial/BAO/FinancialType.php

@@ -188,4 +188,21 @@ public static function getIncomeFinancialType() {
     return $financialType;
   }
 
+  /**
+   * adding permissions for financial types
+   *
+   *
+   * @param array $permissions an array of permissions
+   */
+  public static function permissionedFinancialTypes(&$permissions) {
+    $financialTypes = CRM_Contribute_PseudoConstant::financialType();
+    $prefix = ts('CiviCRM') . ': ';
+    foreach ($financialTypes as $id => $type) {
+      $permissions['add new contributions of type ' . $type] = $prefix . ts('add new contributions of type ' . $type);
+      $permissions['view contributions of type ' . $type] = $prefix . ts('view contributions of type ' . $type);
+      $permissions['edit contributions of type ' . $type] = $prefix . ts('edit contributions of type ' . $type);
+      $permissions['delete contributions of type ' . $type] = $prefix . ts('delete contributions of type ' . $type);
+    }
+    $permissions['administer CiviCRM Financial Types'] = $prefix . ts('administer CiviCRM Financial Types');
+  }
 }