Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test method eventCreatePaid for php 8.2 #25613

Closed
wants to merge 1 commit into from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 18, 2023

Overview

Fix test method eventCreatePaid for php 8.2

There was another fix in here but it led to a tricky e-notice

@eileenmcnaughton
Copy link
Contributor Author

Ah yes THAT notice

CRM_Event_Form_ParticipantTest::testPaymentAllocationOnMultiLineItemEvent
Failure in api call for Payment create: Undefined variable $CRM16923AnUnreliableMethodHasBeenUserToDeterminePaymentProcessorFromEvent
#0 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/CRM/Financial/BAO/Payment.php(192): civicrm_api3('Contribution', 'completetransac...', Array)
#1 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/api/v3/Payment.php(143): CRM_Financial_BAO_Payment::create(Array)
#2 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_payment_create(Array)
#3 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/Civi/API/Kernel.php(158): Civi\API\Provider\MagicFunctionProvider->invoke(Array)
#4 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest(Array)
#5 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/api/api.php(22): Civi\API\Kernel->runSafe('Payment', 'create', Array)
#6 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/Civi/Test/Api3TestTrait.php(292): civicrm_api('Payment', 'create', Array)
#7 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/Civi/Test/Api3TestTrait.php(173): CRM_Event_Form_ParticipantTest->civicrm_api('Payment', 'create', Array)
#8 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/tests/phpunit/CRM/Event/Form/ParticipantTest.php(172): CRM_Event_Form_ParticipantTest->callAPISuccess('Payment', 'create', Array)
#9 phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/Framework/TestCase.php(1229): CRM_Event_Form_ParticipantTest->testPaymentAllocationOnMultiLineItemEvent()
#10 /home/jenkins/bknix-dfl/build/build-x/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php(235): PHPUnit\Framework\TestCase->runTest()

@eileenmcnaughton eileenmcnaughton changed the title Fix test method eventCreatePaid for php 8.2, address todo Fix test method eventCreatePaid for php 8.2 Feb 18, 2023
@eileenmcnaughton
Copy link
Contributor Author

test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant