Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more webtest cleanup and code improvement #7

Merged
merged 1 commit into from
Mar 1, 2013
Merged

more webtest cleanup and code improvement #7

merged 1 commit into from
Mar 1, 2013

Conversation

pratik-joshi
Copy link
Contributor

more webtest cleanup and code improvement

kurund added a commit that referenced this pull request Mar 1, 2013
@kurund
Merge pull request #7 from pratik-joshi/webtests-cleanup-and-fixes
6610dbb 
more webtest cleanup and code improvement
@kurund kurund merged commit 6610dbb into civicrm:master Mar 1, 2013
rohankatkar pushed a commit to rohankatkar/civicrm-core-master that referenced this pull request Jun 20, 2014
@pradpnayak
Merge pull request civicrm#7 from rohankatkar/VAT_Issue_388
013cc8e 
VAT-388  Added action for Print or Email Invoice. Created template for invoice.
atif-shaikh pushed a commit to atif-shaikh/civicrm-core that referenced this pull request Jul 24, 2014
@kurund
Merge pull request civicrm#7 from dlobo/CRM-12457
ad89e43 
CRM-12457
@davecivicrm davecivicrm mentioned this pull request Oct 7, 2014
Closed
eileenmcnaughton referenced this pull request in eileenmcnaughton/civicrm-core Jan 6, 2015
@eileenmcnaughton
CRM-15680 fix custom data on survey & campaign
bf38705
monishdeb added a commit to monishdeb/civicrm-core that referenced this pull request Jan 14, 2015
@monishdeb
INFRA-132 - Batch civicrm#7
c301f76
kurund added a commit that referenced this pull request Jan 14, 2015
@kurund
Merge pull request #4936 from monishdeb/INFRA-32
22aaf44 
INFRA-132 - Batch #7
Edzelopez added a commit to Edzelopez/civicrm-core that referenced this pull request Mar 17, 2015
@Edzelopez
Merge pull request civicrm#7 from Edzelopez/CIVI-28
6a1ec96 
CIVI-28 Modified functionality for offline contribution page
Kajakaran pushed a commit to Kajakaran/civicrm-core that referenced this pull request Apr 20, 2015
@deepak-srivastava
Merge pull request civicrm#7 from Kajakaran/dedupe-fixes
4f5a628 
General search fix and if conflict is present in url then show 'conflict' column in search results
MegaphoneJon pushed a commit to MegaphoneJon/civicrm-core that referenced this pull request Apr 26, 2015
@agh1
Merge pull request civicrm#7 from PalanteJon/status-page
1039eae 
CRM-13283 - xml for StatusPreference entity
eileenmcnaughton referenced this pull request in eileenmcnaughton/civicrm-core Sep 14, 2015
@eileenmcnaughton
Merge pull request #7 from seamuslee001/fuzion_improvements
58ff9d7 
Missing Commits from Fuzion's repo
@KarinG KarinG mentioned this pull request Jul 15, 2016
Closed
@KarinG KarinG mentioned this pull request Aug 7, 2016
Closed
f2boot pushed a commit to f2boot/civicrm-core that referenced this pull request Sep 25, 2016
@kurund
Merge pull request civicrm#7 from colemanw/cleanup
6b7c62a 
Code cleanup and ts fix
ErichBSchulz pushed a commit to ErichBSchulz/civicrm-core that referenced this pull request Jan 3, 2017
@seamuslee001
Merged in CRM-17364 (pull request civicrm#7)
a7cc53c 
Add in Status Override to Membeship Search options
yashodha pushed a commit to yashodha/civicrm-core that referenced this pull request Feb 10, 2017
@sunilpawar
Merge pull request civicrm#7 from yashodha/events-hidepayment
5cd0029 
CRM-19931 - Payment block is not hidden if fee level with amount zero…
@KarinG KarinG mentioned this pull request Mar 10, 2017
Merged
JohnFF referenced this pull request Apr 20, 2017
@totten
Civi\API\ExternalBatch - Improve test for variables_order/$_ENV
40406b5 
The recent revision #9595 updated `ExternalBatch` to produce a more
informative error message.  However, in the test environment used by
`flexmailer`, there was exactly 1 value in `$_ENV` (even if
`variables_order` was misconfigured).

This should make the test a bit harder to trip-up by affirmatively checking
for the most common environment variable.

Review note: In the known universe, the only direct references to
`ExternalBatch` are in `CiviUnitTestCase`, so this shouldn't impact any
runtime logic.
mukeshcompucorp pushed a commit to mukeshcompucorp/civicrm-core that referenced this pull request Jan 18, 2018
@guanhuan
Merged in PG-352-update_giftaid_report (pull request civicrm#7)
9a29a9a 
Update giftaid report
@dsnopek dsnopek mentioned this pull request Apr 18, 2018
Merged
@sandrajvillagenetwork sandrajvillagenetwork mentioned this pull request Aug 20, 2018
Merged
seamuslee001 pushed a commit that referenced this pull request Sep 28, 2018
@kcristiano @colemanw
Regenerate sql for Add icons to top-level navigation menu (#7)
e1fa367
mfb pushed a commit to mfb/civicrm-core that referenced this pull request Dec 15, 2018
@colemanw
Merge pull request civicrm#7 from agh1/swap-target-assignee
227b884 
updated jquery tokeninput to 1.6
@eileenmcnaughton eileenmcnaughton mentioned this pull request Oct 7, 2020
Closed
@agileware-justin agileware-justin mentioned this pull request Oct 8, 2020
Merged
@eileenmcnaughton eileenmcnaughton mentioned this pull request May 26, 2021
Closed
@eileenmcnaughton eileenmcnaughton mentioned this pull request Sep 19, 2021
Closed
totten added a commit to totten/civicrm-core that referenced this pull request Nov 30, 2021
@totten
ManagedEntities - Fix permission error during uninstallation (regress…
081629d 
…ion-fix)

Overview
--------

Fixes a recent regression that prevents you from uninstalling extensions via
CLI.  This specifically affects extensions which use managed entities.

Steps to reproduce
------------------

```
cv en afform
cv dis afform
cv ext:uninstall afform
```

Before
-------

```
[bknix-max:~/bknix/build/dmaster/web/sites/all/modules/civicrm] cv en afform && cv dis afform && cv ext:uninstall afform
Enabling extension "org.civicrm.afform"
Disabling extension "org.civicrm.afform"
Uninstalling extension "org.civicrm.afform"
Error: API Call Failed: Array
(
    [entity] => Extension
    [action] => uninstall
    [params] => Array
        (
            [keys] => Array
                (
                    [0] => org.civicrm.afform
                )

            [debug] => 1
            [version] => 3
        )

    [result] => Array
        (
            [error_code] => unauthorized
            [entity] => Extension
            [action] => uninstall
            [trace] => #0 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(147): Civi\API\Kernel->authorize(Object(Civi\Api4\Provider\ActionObjectProvider), Object(Civi\Api4\Generic\DAODeleteAction))
 #1 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAODeleteAction))
 #2 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute()
 civicrm#3 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(467): civicrm_api4('OptionValue', 'delete', Array)
 civicrm#4 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(303): CRM_Core_ManagedEntities->removeStaleEntity(Object(CRM_Core_DAO_Managed))
 civicrm#5 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(134): CRM_Core_ManagedEntities->reconcileUnknownModules()
 civicrm#6 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(409): CRM_Core_ManagedEntities->reconcile()
 civicrm#7 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Extension/Manager.php(483): CRM_Core_Invoke::rebuildMenuAndCaches(true)
 civicrm#8 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/v3/Extension.php(183): CRM_Extension_Manager->uninstall(Array)
 civicrm#9 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_extension_uninstall(Array)
 civicrm#10 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(149): Civi\API\Provider\MagicFunctionProvider->invoke(Array)
 civicrm#11 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest(Array)
 civicrm#12 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(22): Civi\API\Kernel->runSafe('Extension', 'uninstall', Array)
 civicrm#13 phar:///home/me/bknix/bin/cv/src/Command/BaseCommand.php(49): civicrm_api('Extension', 'uninstall', Array)
 civicrm#14 phar:///home/me/bknix/bin/cv/src/Command/ExtensionUninstallCommand.php(63): Civi\Cv\Command\BaseCommand->callApiSuccess(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput), 'Extension', 'uninstall', Array)
 civicrm#15 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Command/Command.php(257): Civi\Cv\Command\ExtensionUninstallCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#16 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(850): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#17 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRunCommand(Object(Civi\Cv\Command\ExtensionUninstallCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#18 phar:///home/me/bknix/bin/cv/src/Application.php(46): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#19 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(124): Civi\Cv\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#20 phar:///home/me/bknix/bin/cv/src/Application.php(15): Symfony\Component\Console\Application->run()
 civicrm#21 phar:///home/me/bknix/bin/cv/bin/cv(27): Civi\Cv\Application::main('phar:///Users/t...')
 civicrm#22 /home/me/bknix/bin/cv(14): require('phar:///Users/t...')
 civicrm#23 {main}
            [is_error] => 1
            [error_message] => Authorization failed
        )

)
```

After
-----

Works

Comment
-------

I encountered this while working on E2E test-coverage for other changes.
The E2E test coverage had worked on a previous iteration of 5.45.alpha1 but
failed when I rebased. Consequently, this means

You can see a prior draft of the E2E test [here](https://github.com/totten/shimmy/blob/master-reorg/shimmy/tests/phpunit/E2E/Shimmy/LifecycleTest.php#L56-L77).
However, it's being reworked as a core patch.

I'd suggest accepting this without a test - because (a) it's a regression and (b) there will be coverage from the pending change.
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jan 12, 2022
Merged
@eileenmcnaughton eileenmcnaughton mentioned this pull request Mar 1, 2022
Merged
@ginkgomzd ginkgomzd mentioned this pull request Apr 26, 2022
Merged
@eileenmcnaughton eileenmcnaughton mentioned this pull request Feb 18, 2023
Closed
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jul 27, 2023
Merged
@eileenmcnaughton eileenmcnaughton mentioned this pull request Aug 23, 2023
Merged
@eileenmcnaughton eileenmcnaughton mentioned this pull request Sep 18, 2023
Closed
@eileenmcnaughton eileenmcnaughton mentioned this pull request Oct 11, 2023
Merged
@eileenmcnaughton eileenmcnaughton mentioned this pull request Nov 8, 2023
Merged
This was referenced Jan 4, 2024
Merged
Closed
This was referenced Jun 19, 2024
Closed
Merged
totten pushed a commit that referenced this pull request Sep 5, 2024
@eileenmcnaughton
Suppress system check as it crashes with
f187056 
CRM_Event_Page_EventInfoTest::testFullMessage
Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail"
#0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail")
#1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail")
#2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail")
#3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail")
#4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3))
#5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59))
#6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules()
#7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE)
#8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE)
#9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus()
#10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll()
#11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts()
#12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()
ufundo referenced this pull request in ufundo/civicrm-core Sep 11, 2024
@eileenmcnaughton @ufundo
Suppress system check as it crashes with
e1c3876 
CRM_Event_Page_EventInfoTest::testFullMessage
Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail"
#0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail")
#1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail")
#2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail")
#3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail")
#4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3))
#5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59))
#6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules()
#7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE)
#8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE)
civicrm#9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus()
civicrm#10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll()
civicrm#11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts()
civicrm#12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()
ufundo referenced this pull request in ufundo/civicrm-core Nov 13, 2024
Merge branch 'v0.5' into 'main'
6ef43ca 
Version 5.0

Closes #5, #8, and #7

See merge request extensions/riverlea!3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratik-joshi @kurund