Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crm 11534 #11

Merged
merged 2 commits into from
Mar 2, 2013
Merged

Crm 11534 #11

merged 2 commits into from
Mar 2, 2013

Conversation

davecivicrm
Copy link
Contributor

Fixes to allow WebTest_Contribute_AddPricesetTest to complete. Includes a markup change in Set.tpl (eliminate duplicate id value).

kurund added a commit that referenced this pull request Mar 2, 2013
@kurund
Merge pull request #11 from davecivicrm/CRM-11534
5af3d50 
Crm 11534
@kurund kurund merged commit 5af3d50 into civicrm:master Mar 2, 2013
rohankatkar pushed a commit to rohankatkar/civicrm-core-master that referenced this pull request Jun 20, 2014
@pradpnayak
Merge pull request civicrm#11 from dpradeep/VAT-88-New
bd9a7fa 
VAT-88 Removed hardcode query during upgrade.
atif-shaikh pushed a commit to atif-shaikh/civicrm-core that referenced this pull request Jul 24, 2014
@kurund
Merge pull request civicrm#11 from yashodha/master
1509e1c 
worked on CRM-13322
@davecivicrm davecivicrm mentioned this pull request Oct 7, 2014
Closed
eileenmcnaughton referenced this pull request in eileenmcnaughton/civicrm-core Jan 6, 2015
@eileenmcnaughton
CRM-15680 fix custom data on survey & campaign
bf38705
Edzelopez added a commit to Edzelopez/civicrm-core that referenced this pull request Mar 17, 2015
@Edzelopez
Merge pull request civicrm#11 from Edzelopez/CIVI-28
c8c3890 
CIVI-28 Added check for permissions while search results are being displayed on contribution search, advanced search and contact summary page (Contributions tab)
deepak-srivastava added a commit to veda-consulting/civicrm-core that referenced this pull request Apr 23, 2015
@deepak-srivastava
Merge pull request civicrm#11 from mathavanveda/dedupe-workflow-45-tr…
8a9576a 
…-highlight

add class for tr to highlight selected
MegaphoneJon pushed a commit to MegaphoneJon/civicrm-core that referenced this pull request Apr 27, 2015
@agh1
Merge pull request civicrm#11 from ginkgostreet/status-page-1
6b34de3 
CRM-13823 find status preference by name/domain combo
seamuslee001 pushed a commit to seamuslee001/civicrm-core that referenced this pull request Oct 19, 2015
@eileenmcnaughton
Merge pull request civicrm#11 from seamuslee001/CRM-17303-Fuzion
6cbbf2f 
Crm 17303 for Fuzion 4.6 repo
@KarinG KarinG mentioned this pull request Jul 15, 2016
Closed
@KarinG KarinG mentioned this pull request Aug 7, 2016
Closed
f2boot pushed a commit to f2boot/civicrm-core that referenced this pull request Sep 25, 2016
@colemanw
Merge pull request civicrm#11 from dlobo/CRM-12384
91dd2eb 
CRM-12384
ErichBSchulz pushed a commit to ErichBSchulz/civicrm-core that referenced this pull request Jan 3, 2017
@seamuslee001
Merged in atrium-3780 (pull request civicrm#11)
11f1e26 
Atrium 3780 and CRM-17650 CRM-17307 ensure replyto_email is updated when from is updated
JohnFF referenced this pull request Apr 20, 2017
@totten
Civi\API\ExternalBatch - Improve test for variables_order/$_ENV
40406b5 
The recent revision #9595 updated `ExternalBatch` to produce a more
informative error message.  However, in the test environment used by
`flexmailer`, there was exactly 1 value in `$_ENV` (even if
`variables_order` was misconfigured).

This should make the test a bit harder to trip-up by affirmatively checking
for the most common environment variable.

Review note: In the known universe, the only direct references to
`ExternalBatch` are in `CiviUnitTestCase`, so this shouldn't impact any
runtime logic.
@dsnopek dsnopek mentioned this pull request Apr 18, 2018
Merged
@sandrajvillagenetwork sandrajvillagenetwork mentioned this pull request Aug 20, 2018
Merged
eileenmcnaughton pushed a commit that referenced this pull request Nov 7, 2018
@alifrumin @agh1
first stab at 5.7.0 releasenotes (#11)
ee26e2c 
* adding links to gitlab

* moving obvious misc changes

* adding notes

* more noes

* wrapping

* first stab at release notes
seamuslee001 pushed a commit to seamuslee001/civicrm-core that referenced this pull request Nov 8, 2018
@alifrumin @seamuslee001
first stab at 5.7.0 releasenotes (civicrm#11)
5017b87 
* adding links to gitlab

* moving obvious misc changes

* adding notes

* more noes

* wrapping

* first stab at release notes
mfb pushed a commit to mfb/civicrm-core that referenced this pull request Dec 15, 2018
@kurund
Merge pull request civicrm#11 from twomice/CRM-12460
b74393e 
CRM-12460
@eileenmcnaughton eileenmcnaughton mentioned this pull request May 26, 2021
Closed
totten added a commit to totten/civicrm-core that referenced this pull request Nov 30, 2021
@totten
ManagedEntities - Fix permission error during uninstallation (regress…
081629d 
…ion-fix)

Overview
--------

Fixes a recent regression that prevents you from uninstalling extensions via
CLI.  This specifically affects extensions which use managed entities.

Steps to reproduce
------------------

```
cv en afform
cv dis afform
cv ext:uninstall afform
```

Before
-------

```
[bknix-max:~/bknix/build/dmaster/web/sites/all/modules/civicrm] cv en afform && cv dis afform && cv ext:uninstall afform
Enabling extension "org.civicrm.afform"
Disabling extension "org.civicrm.afform"
Uninstalling extension "org.civicrm.afform"
Error: API Call Failed: Array
(
    [entity] => Extension
    [action] => uninstall
    [params] => Array
        (
            [keys] => Array
                (
                    [0] => org.civicrm.afform
                )

            [debug] => 1
            [version] => 3
        )

    [result] => Array
        (
            [error_code] => unauthorized
            [entity] => Extension
            [action] => uninstall
            [trace] => #0 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(147): Civi\API\Kernel->authorize(Object(Civi\Api4\Provider\ActionObjectProvider), Object(Civi\Api4\Generic\DAODeleteAction))
 #1 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAODeleteAction))
 #2 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute()
 civicrm#3 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(467): civicrm_api4('OptionValue', 'delete', Array)
 civicrm#4 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(303): CRM_Core_ManagedEntities->removeStaleEntity(Object(CRM_Core_DAO_Managed))
 civicrm#5 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(134): CRM_Core_ManagedEntities->reconcileUnknownModules()
 civicrm#6 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(409): CRM_Core_ManagedEntities->reconcile()
 civicrm#7 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Extension/Manager.php(483): CRM_Core_Invoke::rebuildMenuAndCaches(true)
 civicrm#8 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/v3/Extension.php(183): CRM_Extension_Manager->uninstall(Array)
 civicrm#9 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_extension_uninstall(Array)
 civicrm#10 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(149): Civi\API\Provider\MagicFunctionProvider->invoke(Array)
 civicrm#11 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest(Array)
 civicrm#12 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(22): Civi\API\Kernel->runSafe('Extension', 'uninstall', Array)
 civicrm#13 phar:///home/me/bknix/bin/cv/src/Command/BaseCommand.php(49): civicrm_api('Extension', 'uninstall', Array)
 civicrm#14 phar:///home/me/bknix/bin/cv/src/Command/ExtensionUninstallCommand.php(63): Civi\Cv\Command\BaseCommand->callApiSuccess(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput), 'Extension', 'uninstall', Array)
 civicrm#15 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Command/Command.php(257): Civi\Cv\Command\ExtensionUninstallCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#16 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(850): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#17 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRunCommand(Object(Civi\Cv\Command\ExtensionUninstallCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#18 phar:///home/me/bknix/bin/cv/src/Application.php(46): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#19 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(124): Civi\Cv\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
 civicrm#20 phar:///home/me/bknix/bin/cv/src/Application.php(15): Symfony\Component\Console\Application->run()
 civicrm#21 phar:///home/me/bknix/bin/cv/bin/cv(27): Civi\Cv\Application::main('phar:///Users/t...')
 civicrm#22 /home/me/bknix/bin/cv(14): require('phar:///Users/t...')
 civicrm#23 {main}
            [is_error] => 1
            [error_message] => Authorization failed
        )

)
```

After
-----

Works

Comment
-------

I encountered this while working on E2E test-coverage for other changes.
The E2E test coverage had worked on a previous iteration of 5.45.alpha1 but
failed when I rebased. Consequently, this means

You can see a prior draft of the E2E test [here](https://github.com/totten/shimmy/blob/master-reorg/shimmy/tests/phpunit/E2E/Shimmy/LifecycleTest.php#L56-L77).
However, it's being reworked as a core patch.

I'd suggest accepting this without a test - because (a) it's a regression and (b) there will be coverage from the pending change.
@eileenmcnaughton eileenmcnaughton mentioned this pull request Mar 1, 2022
Merged
@ginkgomzd ginkgomzd mentioned this pull request Apr 26, 2022
Merged
This was referenced Jan 4, 2024
Merged
Closed
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jun 19, 2024
Closed
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jun 20, 2024
Merged
totten pushed a commit that referenced this pull request Sep 5, 2024
@eileenmcnaughton
Suppress system check as it crashes with
f187056 
CRM_Event_Page_EventInfoTest::testFullMessage
Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail"
#0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail")
#1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail")
#2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail")
#3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail")
#4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3))
#5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59))
#6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules()
#7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE)
#8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE)
#9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus()
#10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll()
#11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts()
#12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()
ufundo pushed a commit to ufundo/civicrm-core that referenced this pull request Sep 11, 2024
@eileenmcnaughton @ufundo
Suppress system check as it crashes with
e1c3876 
CRM_Event_Page_EventInfoTest::testFullMessage
Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail"
#0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail")
#1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail")
#2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail")
#3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail")
#4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3))
#5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59))
#6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules()
#7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE)
#8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE)
civicrm#9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus()
civicrm#10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll()
civicrm#11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts()
civicrm#12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()
ufundo pushed a commit to ufundo/civicrm-core that referenced this pull request Nov 13, 2024
@vingle
Extensions table fixes in #5 and civicrm#11, create overwrite file fo…
fd095e5 
…r admin.css, some more docs in readme
ufundo pushed a commit to ufundo/civicrm-core that referenced this pull request Nov 14, 2024
@vingle @ufundo
Extensions table fixes in #5 and civicrm#11, create overwrite file fo…
90c7e7a 
…r admin.css, some more docs in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davecivicrm @kurund