Skip to content

supported-releases: update testing coverage#779

Merged
jetstack-bot merged 3 commits intocert-manager:masterfrom
maelvls:update-supported-releases-again
Dec 20, 2021
Merged

supported-releases: update testing coverage#779
jetstack-bot merged 3 commits intocert-manager:masterfrom
maelvls:update-supported-releases-again

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Dec 16, 2021

When looking at Ashley's #778, I noticed that our supported testing was not up to date.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 16, 2021
@netlify
Copy link

netlify bot commented Dec 16, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: e0886a9

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61bf46eb33004d00077064d1

😎 Browse the preview: https://deploy-preview-779--cert-manager-website.netlify.app/docs/installation/supported-releases

maelvls
maelvls commented Dec 16, 2021
View reviewed changes
content/en/docs/installation/supported-releases.md Outdated
Comment on lines +195 to +194
| PRs | [`presubmits.yaml`][] | [`presubmits-blocking`][] | 1.22 | On each PR |
| master | [`periodics.yaml`][] | [`master`][] | 1.18 → 1.23 | Every 2 hours |
| release-1.7 | [`next-periodics.yaml`][] | [`next`][] | 1.18 → 1.23 | Every 2 hours |
| release-1.6 | [`previous-periodics.yaml`][] | [`previous`][] | 1.18 → 1.23 | Every 2 hours |
| release-1.5 | N/A | | N/A | N/A |
Copy link
Member Author

@maelvls maelvls Dec 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our presubmit task set with always_run: true is currently using Kubernetes 1.22:

https://github.com/jetstack/testing/blob/b087a1c3bc04f085af1b2dcdfb00be2ef9366a8f/config/jobs/cert-manager/cert-manager-presubmits.yaml#L463

Is that expected? Shouldn't we use 1.23 instead?

Copy link
Member

@SgtCoDFish SgtCoDFish Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know how we choose the "default" k8s version to test against. The latest stable seems like a good choice, which would imply we should upgrade + test against 1.23, but there are potentially quite a few variables in making that choice and it maybe needs more thought. 🤔

I certainly think there's nothing wrong with 1.22 for now!

Copy link
Member

@SgtCoDFish SgtCoDFish Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're also only running periodics for 1.23 once a day currently: https://github.com/jetstack/testing/blob/b087a1c3bc04f085af1b2dcdfb00be2ef9366a8f/config/jobs/cert-manager/cert-manager-periodics.yaml#L330

@maelvls
supported-releases: update testing coverage
37d6065 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls maelvls force-pushed the update-supported-releases-again branch from 7e4237e to 37d6065 Compare December 16, 2021 13:15
SgtCoDFish
SgtCoDFish reviewed Dec 16, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I totally didn't even think about this part of the doc!

One little comment from me!

content/en/docs/installation/supported-releases.md Outdated
|:--------------:|:------------------------------|:--------------------------|:--------------------------:|:-------------:|
| PRs | [`presubmits.yaml`][] | [`presubmits-blocking`][] | 1.22 | On each PR |
| master | [`periodics.yaml`][] | [`master`][] | 1.18 → 1.23 | Every 2 hours |
| release-1.7 | [`next-periodics.yaml`][] | [`next`][] | 1.18 → 1.23 | Every 2 hours |
Copy link
Member

@SgtCoDFish SgtCoDFish Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: We're not currently running any tests against release-next because we've not cut an alpha yet and so release-1.7 isn't being fast-forwarded. That was done in cert-manager/testing#606 - as such, next-periodics.yaml is currently a 404; those periodics will return when we cut an alpha.

It might be worth removing the release-1.7 line entirely (and the next-periodics.yaml link on line 198) for now? We can add back in when we re-enable the periodics

SgtCoDFish
SgtCoDFish approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Thanks for this! One nitpick but not a reason to block; feel free to unhold if you don't fancy changing it 😁

content/en/docs/installation/supported-releases.md Outdated
| release-1.6 | [`next-periodics.yaml`][] | [`next`][] | 1.16 → 1.22 | Every 2 hours |
| release-1.5 | [`previous-periodics.yaml`][] | [`previous`][] | 1.16 → 1.22 | Every 2 hours |
| release-1.4 | N/A | | N/A | N/A |
As of 16 Dec 2021, Our testing coverage is:
Copy link
Member

@SgtCoDFish SgtCoDFish Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (non-blocking):

Suggested change
As of 16 Dec 2021, Our testing coverage is:
As of 16 Dec 2021, our testing coverage is:

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2021
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@maelvls @SgtCoDFish
supported-releases: typo "Our testing coverage"
e0886a9 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2021
@SgtCoDFish
Copy link
Member

SgtCoDFish commented Dec 20, 2021

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maelvls
Copy link
Member Author

maelvls commented Dec 20, 2021

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2021
@jetstack-bot jetstack-bot merged commit 6044f16 into cert-manager:master Dec 20, 2021
@jetstack-bot jetstack-bot mentioned this pull request Dec 20, 2021
Merged
@maelvls maelvls mentioned this pull request Dec 20, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maelvls @SgtCoDFish @jetstack-bot