Skip to content

release-process: mention the removal/re-enabling of next periodics#782

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
maelvls:release-process-update
Dec 20, 2021
Merged

release-process: mention the removal/re-enabling of next periodics#782
jetstack-bot merged 1 commit intocert-manager:masterfrom
maelvls:release-process-update

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Dec 20, 2021

As per #779, @SgtCoDFish made the point that the links in "next periodic" line should be removed until we have released an alpha.0. In this PR, I add more steps in the release process so that we don't forget about those steps.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 20, 2021
@netlify
Copy link

netlify bot commented Dec 20, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 0da5999

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61c06b4ed5743200084863a8

😎 Browse the preview: https://deploy-preview-782--cert-manager-website.netlify.app/docs/contributing/release-process

SgtCoDFish
SgtCoDFish approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Obvious improvement, great stuff. Thanks 👍

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 5cda788 into cert-manager:master Dec 20, 2021
@jetstack-bot jetstack-bot mentioned this pull request Dec 20, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maelvls @jetstack-bot @SgtCoDFish