Skip to content

Remove old tests + run release-next periodics less frequently#606

Merged
jetstack-bot merged 5 commits intocert-manager:masterfrom
SgtCoDFish:nonext
Nov 3, 2021
Merged

Remove old tests + run release-next periodics less frequently#606
jetstack-bot merged 5 commits intocert-manager:masterfrom
SgtCoDFish:nonext

Conversation

@SgtCoDFish
Copy link
Member

@SgtCoDFish SgtCoDFish commented Oct 29, 2021

See individual commit messages for more information

See this comment for more details about testing on release-1.7

@SgtCoDFish
Remove k8s 1.16 and 1.17 tests for master / release-1.7
b199ef6 
Neither version will be supported by cert-manager 1.7 so there's no
point continuing to test against them

(GKE and EKS both EOL k8s 1.17 in Nov 2021, while cert-manager 1.7 is
scheduled for release in Dec 2021)

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@SgtCoDFish
Run release-next periodics once a week
2ca9ed7 
Until we first release an alpha for cert-manager 1.7, the release-1.7
branch isn't going to change. Rather than deleting them entirely, we
can run them much less often to save resources (while still having some
kind of a test)

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2021
jakexks
jakexks previously approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly red PRs are great

I agree with your comment that periodic testing of release-next isn't that useful, as we will PR in to the main branch often, which runs all the tests anyway.

/lgtm
/hold

Holding for a second review if you want

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@SgtCoDFish
remove 1.16 and 1.17 as options on presubmits
3755ec8 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@SgtCoDFish
remove 1.16 tests for release-previous
934c65f 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@SgtCoDFish
Copy link
Member Author

SgtCoDFish commented Oct 29, 2021 •
edited
Loading

Even more red now! 😁 😁 😁

so_good

irbekrm
irbekrm previously approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

I've left a comment on the changed 'release-next' periodic, but it's optional, feel free to unhold if you disagree

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2021
@SgtCoDFish
remove release-next periodics entirely
8ea6ae4 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2021
@SgtCoDFish
Copy link
Member Author

SgtCoDFish commented Nov 3, 2021

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2021
@jetstack-bot jetstack-bot merged commit 226fb73 into cert-manager:master Nov 3, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 3, 2021

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-periodics.yaml using file config/jobs/cert-manager/cert-manager-periodics.yaml
  • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager-presubmits.yaml
  • key cert-manager-release-next-periodics.yaml using file ``
  • key cert-manager-release-previous-periodics.yaml using file config/jobs/cert-manager/release-previous/cert-manager-release-previous-periodics.yaml
  • key cert-manager-release-previous-presubmits.yaml using file config/jobs/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml
Details

In response to this:

See individual commit messages for more information

See this comment for more details about testing on release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, jakexks, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish SgtCoDFish deleted the nonext branch November 3, 2021 13:21
@SgtCoDFish SgtCoDFish mentioned this pull request Dec 16, 2021
Merged
@irbekrm irbekrm mentioned this pull request Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakexks jakexks jakexks left review comments

+1 more reviewer

@irbekrm irbekrm irbekrm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jakexks jakexks

@irbekrm irbekrm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SgtCoDFish @jetstack-bot @jakexks @irbekrm