1.7.3#2042
Merged
gastonponti merged 9 commits intorelease/1.7.xfrom Mar 13, 2023
Merged
Conversation
Prior to this change the RoundStateDB was never closed. This could result in leaked goroutines from its internal leveldb instance. This change caused the TestStartStopValidators e2e test to fail because changing the rsdb open to be in the startup code, slowed down the start method for core this caused the gossiping of the manually added peers (done in the test after starting each previously stopped node )to happen after the validator peer handler had removed all the peers resulting in gossiping certs to no one. Thus leaving the network in a disconnected state. The fix was really hacky, but just to wait 250ms after starting a node and hoping that the validator peer handler will have removed nodes by that point and then add the peers and then wait a little for them to be registered and then finally gossip to them. Co-authored-by: Paul Lange <palango@users.noreply.github.com>
* update celo-bls-go version to fix issue #2005 * fix go.sum * go mod tidy
The GraphQL-Endpoint did not properly handle post-EIP1559 gas fees. To get the correct results based on the respective baseFee, we have to take a look at the used feeCurrency. To get at least some test coverage for this, I added one EIP-1559 transaction to the test data. This is still far from a thorough coverage of all relevant cases (different feeCurrency, the base fee is 0 in the test, so bugs for proper values might be hidden).
Contributor
|
Coverage from tests in coverage: 47.8% of statements across all listed packagescoverage: 53.1% of statements in consensus/istanbul coverage: 42.9% of statements in consensus/istanbul/announce coverage: 56.0% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 55.6% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 32f854e81e |
Description Update the branch that we use to track the last deployed core contracts on Mainnet Other changes Fix mycelo to handle all the changes. Add GrandaMento contract that was added before but we missed
Collaborator
Author
|
iOS CI is broken as was removed upstream. |
Contributor
|
All tests are passing. The ios build was removed as part of a PR that was not cherrypicked for this release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Branch for the next patch release:
Changes included:
E2E_TESTS_FORCE_USE_MYCELOin e2e tests (ci: SetE2E_TESTS_FORCE_USE_MYCELOin e2e tests #1992) (8 weeks ago)