Add local datadir flag and migrate flags#2037
Merged
eelanagaraj merged 1 commit intomasterfrom Mar 7, 2023
Merged
Conversation
|
Coverage from tests in coverage: 50.1% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 42.9% of statements in consensus/istanbul/announce coverage: 56.0% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 63.0% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 10d86efd55 |
eelanagaraj
requested review from
a team,
gastonponti and
palango
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2037 +/- ##
==========================================
+ Coverage 54.82% 54.88% +0.05%
==========================================
Files 688 692 +4
Lines 92542 92747 +205
==========================================
+ Hits 50737 50900 +163
- Misses 37993 38032 +39
- Partials 3812 3815 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
palango
pushed a commit
that referenced
this pull request
Mar 10, 2023
Merged
gastonponti
pushed a commit
that referenced
this pull request
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--datadircannot be passed in as a local flag foruptime report. Per #1914,./build/bin/uptime report --epoch 786 --lookback 12 --valset 110 --datadir ~/chaindata/fastsyncwould fail (though note that./build/bin/uptime --datadir ~/chaindata/fastsync report --epoch 786 --lookback 12 --valset 110worked). This adds--datadiras a local flag as well and migrates the flags to global context (so that the datadir is instantiated properly).Tested
Related issues
Backwards compatibility
Yes, just adds the ability to add the datadir param as a local flag (in addition to global).