ci: Set E2E_TESTS_FORCE_USE_MYCELO in e2e tests#1992
Merged
palango merged 1 commit intocelo-org:masterfrom Jan 12, 2023
Merged
Conversation
palango
requested review from
gastonponti,
hbandura and
mcortesi
and removed request for
a team
Codecov ReportBase: 54.82% // Head: 54.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1992 +/- ##
==========================================
+ Coverage 54.82% 54.84% +0.01%
==========================================
Files 688 695 +7
Lines 92542 93255 +713
==========================================
+ Hits 50737 51144 +407
- Misses 37993 38262 +269
- Partials 3812 3849 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
palango
force-pushed
the
paul/set-celotool-envvar
branch
3 times, most recently
from
761cccf to
b16180e
Compare
palango
force-pushed
the
paul/set-celotool-envvar
branch
from
b16180e to
fbd4ff3
Compare
Collaborator
Author
|
The docker image build is now working for PRs from forks as well, we just need to change the required check in github. |
palango
added a commit
that referenced
this pull request
Mar 10, 2023
palango
added a commit
that referenced
this pull request
Mar 10, 2023
Merged
gastonponti
pushed a commit
that referenced
this pull request
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently
E2E_TESTS_FORCE_USE_MYCELOis set via the CircleCI project settings. Those settings are not forwarded to CI running for PRs from forked repositories. This leads to problems like in this PR (build).Instead, we define the variable directly in the CI config.
I created this PR from my fork, so this should test it.