Merged
Conversation
palango
requested review from
hbandura and
piersy
and removed request for
a team
palango
commented
Feb 20, 2023
palango
force-pushed
the
paul/fix-tracer-gas
branch
from
1f791de to
021618e
Compare
palango
changed the title
|
Coverage from tests in coverage: 43.9% of statements across all listed packagescoverage: 47.7% of statements in consensus/istanbul coverage: 23.7% of statements in consensus/istanbul/announce coverage: 54.3% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 55.5% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 5425b7de98 |
Codecov ReportBase: 54.82% // Head: 54.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
+ Coverage 54.82% 54.85% +0.02%
==========================================
Files 688 695 +7
Lines 92542 93274 +732
==========================================
+ Hits 50737 51165 +428
- Misses 37993 38257 +264
- Partials 3812 3852 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
palango
force-pushed
the
paul/fix-tracer-gas
branch
from
021618e to
62aa19d
Compare
carterqw2
reviewed
Feb 20, 2023
gastonponti
reviewed
Feb 23, 2023
Contributor
gastonponti
left a comment
gastonponti
left a comment
There was a problem hiding this comment.
The majority are nits, and use the actual number that the mock will call for the gasPrice
Fix the tracing module to correctly use the base fee when calculating gas prices.
palango
force-pushed
the
paul/fix-tracer-gas
branch
from
8846a39 to
a73449d
Compare
palango
force-pushed
the
paul/fix-tracer-gas
branch
from
3955cbb to
8141184
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the tracing module to correctly use the base fee when calculating
gas prices.
Tested
Adds a regression test.
Related issues
Resolves #2002