Update core-contracts.v8#2010
Merged
gastonponti merged 5 commits intomasterfrom Feb 15, 2023
Merged
Conversation
gastonponti
requested review from
hbandura and
piersy
and removed request for
a team and
piersy
gastonponti
force-pushed
the
gastonponti/update-contracts-v8
branch
from
75f1c22 to
a164240
Compare
Contributor
|
Coverage from tests in coverage: 47.2% of statements across all listed packagescoverage: 52.6% of statements in consensus/istanbul coverage: 40.0% of statements in consensus/istanbul/announce coverage: 54.6% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 56.6% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: db2670421d |
Codecov ReportBase: 54.82% // Head: 54.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2010 +/- ##
==========================================
- Coverage 54.82% 54.81% -0.02%
==========================================
Files 688 695 +7
Lines 92542 93258 +716
==========================================
+ Hits 50737 51119 +382
- Misses 37993 38299 +306
- Partials 3812 3840 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
This solves the genesis errors I was getting before. |
carterqw2
approved these changes
Feb 15, 2023
Merged
palango
pushed a commit
that referenced
this pull request
Mar 10, 2023
Description Update the branch that we use to track the last deployed core contracts on Mainnet Other changes Fix mycelo to handle all the changes. Add GrandaMento contract that was added before but we missed
gastonponti
added a commit
that referenced
this pull request
Mar 13, 2023
Description Update the branch that we use to track the last deployed core contracts on Mainnet Other changes Fix mycelo to handle all the changes. Add GrandaMento contract that was added before but we missed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the branch that we use to track the last deployed core contracts on Mainnet
Other changes
Fix mycelo to handle all the changes. Add GrandaMento contract that was added before but we missed
Tested
Create the genesis block and run the tests
Related issues
Backwards compatibility
Yes