Skip to content

feat(goose-cli): add cargo feature to disable update command #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kskarthik wants to merge 24 commits into from
Closed

feat(goose-cli): add cargo feature to disable update command #5846

kskarthik wants to merge 24 commits into from

Conversation

@kskarthik
Copy link
Contributor

@kskarthik kskarthik commented Nov 22, 2025 •
edited
Loading

Summary

Added a feature to the goose-cli crate to disable the update command.

Usecase: I have packaged goose for openSUSE Tumbleweed & i had to patch the build to disable update.

This feature comes handy instead of patching the code & quiet helpful for other distro package maintainers as well 🙂

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Tested manually

Screenshots/Demos (for UX changes)

Before:

$: goose update
WINDIR: <not set>
OSTYPE: linux
uname -s: Linux
uname -m: x86_64
PWD: /home/sai/my/code/goose-src
Detected OS: linux with ARCH x86_64
...

After:

$: cargo build --package goose-cli --features disable-update

$: goose update
Error: This command is disabled

@kskarthik kskarthik changed the title feat(goose-cli): add cargo feature to disable update feat(goose-cli): add cargo feature to disable update command Nov 22, 2025
michaelneale
michaelneale approved these changes Nov 24, 2025
View reviewed changes
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @kskarthik, I can appreciate with packagers you want to have this.

@michaelneale michaelneale self-assigned this Nov 24, 2025
@kskarthik
Copy link
Contributor Author

kskarthik commented Nov 24, 2025

Thanks for reviewing this! @michaelneale

I guess that the failing CI test above can be ignored, just an issue with npm package lock

@michaelneale
Copy link
Collaborator

michaelneale commented Nov 25, 2025

@kskarthik if you update to main - then it should build now, thanks

@kskarthik kskarthik requested a review from a team as a code owner November 25, 2025 05:00
@kskarthik
Copy link
Contributor Author

kskarthik commented Nov 25, 2025

Done

DOsinga and others added 22 commits November 26, 2025 14:05
@DOsinga @kskarthik
Handle 404s (block#5791)
f749dd0 
Co-authored-by: Douwe Osinga <douwe@squareup.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@kskarthik
feat(goose-cli): add feature to disable update
24ef8b3 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@michaelneale @kskarthik
don't need one line comment
8c373d7 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@tlongwell-block @kskarthik
Add /agent/stop endpoint, make max active agents configurable (block#…
110ee8b 
…5826)

Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@vaibhavgeek @claude @kskarthik
fix: Add backward compatibility for conversationCompacted message type (
20fb5d7 
block#5819)

Signed-off-by: Vaibhav Maheshwari <vaibhav.dkm@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@katzdave @kskarthik
Add out of context compaction test via error proxy (block#5805)
a7c0626 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@zanesq @kskarthik
Next camp refactor live (block#5706)
e0c50a8 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@emma-squared @kskarthik
markdown export from URL (block#5830)
bb8da23 
* Add Markdown export of any doc page by appending `.md` to the URL
* New "View as Markdown" dropdown menu from the "copy page" button

Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@zanesq @kskarthik
fix sessions coming back with empty messages (block#5841)
c074d50 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@DOsinga @kskarthik
Cors and token (block#5850)
c08c89e 
Co-authored-by: Douwe Osinga <douwe@squareup.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@DOsinga @kskarthik
Add scheduler to diagnostics (block#5849)
805a243 
Co-authored-by: Douwe Osinga <douwe@squareup.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@baxen @kskarthik
[fix] generic check for gemini compat (block#5842)
948370a 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@michaelneale @kskarthik
urgent: github broke runners for macos (block#5853)
54994a0 
urgent need for runner failure

Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@michaelneale @kskarthik
feat: implement SKILLS.md - claude compatibility. (block#5760)
3ff7d0e 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@Abhijay007 @kskarthik
feat : add ability to see error message in toast (block#5851)
ed39314 
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@Abhijay007 @kskarthik
feat : add support for math / science symbology via katex (block#5773)
5a9d848 
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@michaelneale @kskarthik
chore: some old code hanging around, and mention configure cli (block…
9b46411 
…#5822)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@alexhancock @Pdash-exceeds @kskarthik
fix(block#5626 block#5832): handle multiple content chunks & images b…
1976949 
…etter (block#5839)

Co-authored-by: Pradeepta Dash <pradeepta@exceeds.ai>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@DOsinga @kskarthik
Fix multi tool calling (block#5855)
73a3cba 
Co-authored-by: Douwe Osinga <douwe@squareup.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@dianed-square @kskarthik
docs: lowercase goose in getting-started and guides topics (block#5857)
af295b1 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@dianed-square @kskarthik
docs: lowercase goose in remaining topics (block#5861)
8ab6604 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@sam-at-block @kskarthik
docs: add DataHub MCP server extension documentation (block#5769)
cc758f7 
Signed-off-by: Sam Osborn <samosborn@squareup.com>
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@michaelneale @kskarthik
goose remote access (block#5251)
fa5b4f2 
Signed-off-by: Sai Karthik <kskarthik@disroot.org>
@kskarthik kskarthik closed this Nov 26, 2025
@kskarthik kskarthik deleted the disable-cli-update branch November 26, 2025 08:56
@kskarthik kskarthik mentioned this pull request Nov 26, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelneale michaelneale michaelneale approved these changes

Assignees

@michaelneale michaelneale

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.