feat : add ability to see error message in toast #5851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhijay007 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a copy button to error toasts, making it easier for users to copy error messages before using the "Ask Goose" recovery feature. The implementation intelligently adapts the UI based on what actions are available: when both copy and recovery options are present, it uses a compact icon button for copying; when only copying is available, it uses a text button.
Key Changes
- Added copy functionality to error toasts with async clipboard API
- Implemented conditional UI rendering: icon button when both actions available, text button otherwise
- Increased toast width from 380px to 450px to accommodate multiple buttons without overlap
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/desktop/src/toasts.tsx | Added copy handler with clipboard API, conditional button rendering (icon vs text), and tooltip for icon button |
| ui/desktop/src/App.tsx | Increased ToastContainer width to 450px to prevent button overlap |
| ui/desktop/src/styles/main.css | Adjusted close button alignment to center and updated margins for better spacing |
michaelneale
approved these changes
Nov 24, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
Looks good - but haven't had a chance to try it by hand.
Collaborator
|
(hopefully that node error will be resolved on main or by github soon) |
Signed-off-by: Abhijay007 <[email protected]>
angiejones
approved these changes
Nov 24, 2025
Collaborator
|
thank you @Abhijay007! |
michaelneale
added a commit
that referenced
this pull request
Nov 25, 2025
* main: docs: add DataHub MCP server extension documentation (#5769) docs: lowercase goose in remaining topics (#5861) docs: lowercase goose in getting-started and guides topics (#5857) Fix multi tool calling (#5855) fix(#5626 #5832): handle multiple content chunks & images better (#5839) chore: some old code hanging around, and mention configure cli (#5822) feat : add support for math / science symbology via katex (#5773) feat : add ability to see error message in toast (#5851)
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 25, 2025
Signed-off-by: Abhijay007 <[email protected]>
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 26, 2025
Signed-off-by: Abhijay007 <[email protected]> Signed-off-by: Sai Karthik <[email protected]>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Abhijay007 <[email protected]> Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5848
PR Description
This PR aims to adds a copy button to error toasts, allowing users to easily copy the error message before using “Ask Goose.”
Changes Made
ui/desktop/src/toasts.tsx– Added copy button with tooltipui/desktop/src/App.tsx– Increased toast container width from 380px → 450px to so that content fits nicely, and also the cross button doesn't overlapui/desktop/src/styles/main.css– Adjusted close button alignment a bitType of Change
Testing
Tested in the desktop UI by triggering an error and copying it.
Screenshots / Demos (for UX changes)
Before:
After: