chore: some old code hanging around, and mention configure cli #5822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs cleanup of old provider configuration code from the desktop UI and updates the GitHub Copilot provider description to guide users to use the CLI for OAuth setup.
- Removes unused
ProviderRegistry.tsxfile containing legacy provider definitions - Updates GitHub Copilot provider description to mention the
goose configureCLI command
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/desktop/src/components/settings/providers/ProviderRegistry.tsx | Removes entire legacy provider registry file that is no longer referenced in the codebase |
| crates/goose/src/providers/githubcopilot.rs | Updates provider description to inform users about CLI-based OAuth configuration |
Co-authored-by: Copilot <[email protected]>
codefromthecrypt
approved these changes
Nov 24, 2025
Collaborator
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
good tips. thanks for the cleanup
alexhancock
approved these changes
Nov 24, 2025
Collaborator
|
Nice |
michaelneale
added a commit
that referenced
this pull request
Nov 25, 2025
* main: docs: add DataHub MCP server extension documentation (#5769) docs: lowercase goose in remaining topics (#5861) docs: lowercase goose in getting-started and guides topics (#5857) Fix multi tool calling (#5855) fix(#5626 #5832): handle multiple content chunks & images better (#5839) chore: some old code hanging around, and mention configure cli (#5822) feat : add support for math / science symbology via katex (#5773) feat : add ability to see error message in toast (#5851)
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 25, 2025
…#5822) Co-authored-by: Copilot <[email protected]>
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 26, 2025
…#5822) Co-authored-by: Copilot <[email protected]> Signed-off-by: Sai Karthik <[email protected]>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
…#5822) Co-authored-by: Copilot <[email protected]> Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was this old provider code which is no longer needed, and thought I should make it clear for copilot that you currently need to use the cli to do the oauth login.