Skip to content

Conversation

@wpfleger96
Copy link
Collaborator

@wpfleger96 wpfleger96 commented Oct 20, 2025

This PR reapplies all the same changes from #5085 that got reverted, except that this time the DB migration is 🤞 backwards-compatible:

  • Instead of renaming description field to name in the session DB, we add name as a new column and use fallback logic for old sessions without a name
  • This way the DB migration will be forwards and backwards compatible regardless of Goose version

Confirmed that after I ran the migration locally, I can resume a session by name using either new (local build) or old ("system" Goose v1.11.1) Goose

🐚 ~/Development/goose wpfleger/session-name ./target/debug/goose session --resume --name "Open team PagerDuty"
◇  WARNING: The original working directory of this session was set to /Users/wpfleger/Development/goose-fork. Your current directory is /Users/wpfleger/Development/goose. Do you want to switch back to the original working directory?
│  No
│
resuming session | provider: databricks model: goose-claude-4-5-sonnet
    session id: 20251001_94012
    working directory: /Users/wpfleger/Development/goose

goose is running! Enter your instructions, or try asking what goose can do.

Context: ●○○○○○○○○○ 14% (28569/200000 tokens)


~ goose session --resume --name "Open team PagerDuty"
◇  WARNING: The original working directory of this session was set to /Users/wpfleger/Development/goose-fork. Your current directory is /Users/wpfleger. Do you want to switch back to the original working directory?
│  No
│
resuming session | provider: databricks model: goose-claude-4-5-sonnet
    session id: 20251001_94012
    working directory: /Users/wpfleger

goose is running! Enter your instructions, or try asking what goose can do.

Context: ●○○○○○○○○○ 14% (28569/200000 tokens)
( O)>

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

Related Issues

Relates to #5044

@wpfleger96 wpfleger96 marked this pull request as ready for review October 21, 2025 18:48
@wpfleger96 wpfleger96 requested a review from DOsinga October 21, 2025 18:48
@wpfleger96
Copy link
Collaborator Author

@DOsinga this is ready for review now, it has all the same changes from #5085 that got reverted but with this commit that:

  • Create new name column instead of renaming description to name
  • Add fallback logic for historical sessions in the DB that don't have a name

@wpfleger96
Copy link
Collaborator Author

CC: @michaelneale

@wpfleger96
Copy link
Collaborator Author

I've also validated backwards compatibility with net-new sessions:

~ goose
starting session | provider: databricks model: goose-claude-4-5-sonnet
    session id: 20251021_9
    working directory: /Users/wpfleger

goose is running! Enter your instructions, or try asking what goose can do.

Context: ○○○○○○○○○○ 0% (0/200000 tokens)
( O)> this is a test session to validate database backwards compatibility
I understand you want to test database backwards compatibility. To help you effectively, I need a bit more context:
...

~ goose session list | grep 20251021_9
20251021_9 - Validate DB compatibility - 2025-10-21 18:58:18 UTC

~ goose session --resume --name "Validate DB compatibility"
resuming session | provider: databricks model: goose-claude-4-5-sonnet
    session id: 20251021_9
    working directory: /Users/wpfleger

goose is running! Enter your instructions, or try asking what goose can do.

Context: ●○○○○○○○○○ 6% (11102/200000 tokens)
( O)> exit
Closing session. Session ID: 20251021_9

~ ~/Development/goose/target/debug/goose session --resume --name "Validate DB compatibility"
resuming session | provider: databricks model: goose-claude-4-5-sonnet
    session id: 20251021_9
    working directory: /Users/wpfleger

goose is running! Enter your instructions, or try asking what goose can do.

Context: ●○○○○○○○○○ 6% (11102/200000 tokens)
( O)>

* main: (33 commits)
  Add Web Accessibility Auditor recipe to cookbook (#5318)
  To do mcp tutorial (#5317)
  workflows: add a manual trigger option to pr-smoke-test (#5302)
  documenting `goose recipe list` command (#5278)
  add a system prompt snapshot test (#5305)
  fix: handle non exist subrecipe path (#5287)
  Next camp (#5237)
  more lowercasing of TabItem labels (#5307)
  modified docs/tutorials/cicd Github Action's install path to follow download_cli script (#5240)
  Fix artifact download to work across workflow runs (#5304)
  Added extension search (#5283)
  docs: lowercase 'goose' in TabItem labels for consistency (#5297)
  feat(prompts): add format to save code snippet (#5007)
  fix: use Windows-compatible default path for CLI installation (#5221)
  feat: add Test Coverage Optimizer recipe (#5118) (#5272)
  Upgrade node to fix canary (#5301)
  Remove reliance on localstorage for pendingScheduleDeepLink when scheduling a recipe (#5290)
  Add historical tracking with trend indicators using artifacts (#5295)
  roll back vite and electron package upgrades breaking canary win and linux (#5292)
  Revert "Revert "Rewrite extension management tools"" (#5273)
  ...
* main:
  Replace compaction notifications with system notifications (#5218)
  Diagnostics (#5323)
  Fix gemini again (#5308)
  fix: synchronize local message state after conversation compaction (#5315)
  docs: replace broken links with working links (#5266)
* main:
  Add tech-article-explainer recipe (#5333)
  doc: added beta banner for old blog post (#5332)
  feat: add code refactor recipe (#5320)
  Security audit recipe (#5319)
  feat: add generate commit message recipe (#5326)
  fix: remove dependency on gsap library (#5330)
  feat: dynamically load ollama models (#5309)
  fix: skip temperature for goose-gpt-5 model (#5311)
* main:
  Create recipe dir on save (#5337)
  docs: Update Discord link (#5335)
  [recipe workflow]: Fix `Invalid revision range` error  (#5334)
@michaelneale
Copy link
Collaborator

When I run just run-ui with this - I only see names for new sessions:

image

But the good news is if I roll back (cli or GUI) I do see all names:

image

should this pick up the description as names for old sessions for display?

@wpfleger96
Copy link
Collaborator Author

@michaelneale this is now fixed 😄

image

* main:
  chore: improve timeout for entering password when running goose ui from source (#5349)
  Fix legacy import (#5343)
  Unify loading goose messages and usechatstream determines chat state (#5306)
  Docs: goose session export and goose session import (#5267)
@wpfleger96 wpfleger96 merged commit 044b227 into main Oct 24, 2025
14 checks passed
@wpfleger96 wpfleger96 deleted the wpfleger/session-name branch October 24, 2025 17:34
zanesq added a commit that referenced this pull request Oct 24, 2025
…ithub.com:block/goose into zane/next-camp/chat-extension-toggle

* 'main' of github.com:block/goose:
  (re)Standardize Session Name Attribute (#5279)

* 'zane/next-camp/chat-extension-toggle' of github.com:block/goose:
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Oct 25, 2025
michaelneale added a commit that referenced this pull request Oct 26, 2025
* main:
  fixing typo in blog metadata (#5382)
  feat: add new blog entry on adopting Goose in the enterprise (#5381)
  Blog/acp intro oct 2024 (#5379)
  feat: add A/B test framework generator recipe (#5378)
  Doc: (blog) - Deep Dive into goose's Extension System and Model Context Protocol (MCP) (#5291)
  Some system prompt tidying (#5313)
  Fix scheduler jobs dates formatting (#5368)
  Use Instructions as Prompt in Scheduler (#5359)
  feat(snowflake): add support for newer Claude 4.5 and 4 models (#5350)
  Add bottom menu extension selection (#5352)
  (re)Standardize Session Name Attribute (#5279)
  chore: improve timeout for entering password when running goose ui from source (#5349)
michaelneale added a commit that referenced this pull request Oct 26, 2025
* main:
  fixing typo in blog metadata (#5382)
  feat: add new blog entry on adopting Goose in the enterprise (#5381)
  Blog/acp intro oct 2024 (#5379)
  feat: add A/B test framework generator recipe (#5378)
  Doc: (blog) - Deep Dive into goose's Extension System and Model Context Protocol (MCP) (#5291)
  Some system prompt tidying (#5313)
  Fix scheduler jobs dates formatting (#5368)
  Use Instructions as Prompt in Scheduler (#5359)
  feat(snowflake): add support for newer Claude 4.5 and 4 models (#5350)
  Add bottom menu extension selection (#5352)
  (re)Standardize Session Name Attribute (#5279)
  chore: improve timeout for entering password when running goose ui from source (#5349)
michaelneale added a commit that referenced this pull request Oct 27, 2025
* main: (54 commits)
  fixing typo in blog metadata (#5382)
  feat: add new blog entry on adopting Goose in the enterprise (#5381)
  Blog/acp intro oct 2024 (#5379)
  feat: add A/B test framework generator recipe (#5378)
  Doc: (blog) - Deep Dive into goose's Extension System and Model Context Protocol (MCP) (#5291)
  Some system prompt tidying (#5313)
  Fix scheduler jobs dates formatting (#5368)
  Use Instructions as Prompt in Scheduler (#5359)
  feat(snowflake): add support for newer Claude 4.5 and 4 models (#5350)
  Add bottom menu extension selection (#5352)
  (re)Standardize Session Name Attribute (#5279)
  chore: improve timeout for entering password when running goose ui from source (#5349)
  Fix legacy import (#5343)
  Unify loading goose messages and usechatstream determines chat state (#5306)
  Docs: goose session export and goose session import (#5267)
  Create recipe dir on save (#5337)
  docs: Update Discord link (#5335)
  [recipe workflow]: Fix `Invalid revision range` error  (#5334)
  Add tech-article-explainer recipe (#5333)
  doc: added beta banner for old blog post (#5332)
  ...
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants