fix: remove dependency on gsap library #5330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOsinga
approved these changes
Oct 22, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Nice! I never liked this library, now that I know they have a doubtful license even better
zanesq
reviewed
Oct 22, 2025
Collaborator
zanesq
left a comment
zanesq
left a comment
There was a problem hiding this comment.
Thanks much needed! Tested locally and animation looks good.
Can we add respecting the users reduced-motion preferences? We didn't do this before but since its front and center animation I think we should (we do this already with the sidebar animations).
if (window.matchMedia && window.matchMedia('(prefers-reduced-motion: reduce)').matches) { set final state and return; }
Collaborator
|
nice one, yeah good catch. |
Contributor
Author
@zanesq let's do that in a separate PR since it changes the behaviour. This PR won't change any behaviour but is just a refactor. |
wpfleger96
added a commit
that referenced
this pull request
Oct 23, 2025
* main: Add tech-article-explainer recipe (#5333) doc: added beta banner for old blog post (#5332) feat: add code refactor recipe (#5320) Security audit recipe (#5319) feat: add generate commit message recipe (#5326) fix: remove dependency on gsap library (#5330) feat: dynamically load ollama models (#5309) fix: skip temperature for goose-gpt-5 model (#5311)
katzdave
added a commit
that referenced
this pull request
Oct 23, 2025
…message # By Better-Boy (3) and others # Via GitHub * 'main' of github.com:block/goose: Create recipe dir on save (#5337) docs: Update Discord link (#5335) [recipe workflow]: Fix `Invalid revision range` error (#5334) Add tech-article-explainer recipe (#5333) doc: added beta banner for old blog post (#5332) feat: add code refactor recipe (#5320) Security audit recipe (#5319) feat: add generate commit message recipe (#5326) fix: remove dependency on gsap library (#5330) feat: dynamically load ollama models (#5309) fix: skip temperature for goose-gpt-5 model (#5311) Replace compaction notifications with system notifications (#5218) # Conflicts: # crates/goose/src/agents/agent.rs
michaelneale
added a commit
that referenced
this pull request
Oct 24, 2025
* main: (77 commits) Fix legacy import (#5343) Unify loading goose messages and usechatstream determines chat state (#5306) Docs: goose session export and goose session import (#5267) Create recipe dir on save (#5337) docs: Update Discord link (#5335) [recipe workflow]: Fix `Invalid revision range` error (#5334) Add tech-article-explainer recipe (#5333) doc: added beta banner for old blog post (#5332) feat: add code refactor recipe (#5320) Security audit recipe (#5319) feat: add generate commit message recipe (#5326) fix: remove dependency on gsap library (#5330) feat: dynamically load ollama models (#5309) fix: skip temperature for goose-gpt-5 model (#5311) Replace compaction notifications with system notifications (#5218) Diagnostics (#5323) Fix gemini again (#5308) fix: synchronize local message state after conversation compaction (#5315) docs: replace broken links with working links (#5266) Add Web Accessibility Auditor recipe to cookbook (#5318) ...
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Oct 25, 2025
gsap's highly limited use in this codebase can easily be achieved using the native JS Web Animations API. Signed-off-by: Blair Allan <[email protected]>
Closed
katzdave
pushed a commit
that referenced
this pull request
Oct 28, 2025
gsap's highly limited use in this codebase can easily be achieved using the native JS Web Animations API.
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
gsap's highly limited use in this codebase can easily be achieved using the native JS Web Animations API. Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change removes a dependency on the
gsaplibrary, used by ui/desktop. The library is used to animate text on the greeting screen on startup.The library is problematic - it is not open source. Instead, it uses this rather badly-written bespoke license:
https://gsap.com/community/standard-license/ This is not an open source license because it has prohibitions on certain competing uses and also it's not clear it even allows commercial distribution.
gsap's highly limited use in this codebase can easily be achieved using the native JS Web Animations API. The Web Animations API is optimised at the browser level so this should perform better too, though that isn't the primary goal of this change.Type of Change
Testing
Manual testing
Screenshots/Demos (for UX changes)
No change in UI from before and after the change.