feat: dynamically load ollama models #5309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
kudos to @eugenepyvovarov |
zanesq
approved these changes
Oct 21, 2025
angelahning
force-pushed
the
aning/ollama
branch
2 times, most recently
from
b5e7b2d to
faa9fe7
Compare
angelahning
force-pushed
the
aning/ollama
branch
from
faa9fe7 to
233d191
Compare
DOsinga
approved these changes
Oct 22, 2025
crates/goose/src/providers/ollama.rs
Outdated
| })) | ||
| } | ||
|
|
||
| /// Fetch the list of available models from Ollama |
|
|
||
| Ok(Some(model_names)) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
this feels more verbos than it needs to be - do we need to sort the models?
| activeProviders.forEach(({ metadata, name }) => { | ||
| if (metadata.known_models) { | ||
| metadata.known_models.forEach((model) => { | ||
| const modelPromises = activeProviders.map(async (p) => { |
Collaborator
There was a problem hiding this comment.
this is near duplicated code or maybe the LLM did it, but suggest to unify it
wpfleger96
added a commit
that referenced
this pull request
Oct 23, 2025
* main: Add tech-article-explainer recipe (#5333) doc: added beta banner for old blog post (#5332) feat: add code refactor recipe (#5320) Security audit recipe (#5319) feat: add generate commit message recipe (#5326) fix: remove dependency on gsap library (#5330) feat: dynamically load ollama models (#5309) fix: skip temperature for goose-gpt-5 model (#5311)
katzdave
added a commit
that referenced
this pull request
Oct 23, 2025
…message # By Better-Boy (3) and others # Via GitHub * 'main' of github.com:block/goose: Create recipe dir on save (#5337) docs: Update Discord link (#5335) [recipe workflow]: Fix `Invalid revision range` error (#5334) Add tech-article-explainer recipe (#5333) doc: added beta banner for old blog post (#5332) feat: add code refactor recipe (#5320) Security audit recipe (#5319) feat: add generate commit message recipe (#5326) fix: remove dependency on gsap library (#5330) feat: dynamically load ollama models (#5309) fix: skip temperature for goose-gpt-5 model (#5311) Replace compaction notifications with system notifications (#5218) # Conflicts: # crates/goose/src/agents/agent.rs
michaelneale
added a commit
that referenced
this pull request
Oct 24, 2025
* main: (77 commits) Fix legacy import (#5343) Unify loading goose messages and usechatstream determines chat state (#5306) Docs: goose session export and goose session import (#5267) Create recipe dir on save (#5337) docs: Update Discord link (#5335) [recipe workflow]: Fix `Invalid revision range` error (#5334) Add tech-article-explainer recipe (#5333) doc: added beta banner for old blog post (#5332) feat: add code refactor recipe (#5320) Security audit recipe (#5319) feat: add generate commit message recipe (#5326) fix: remove dependency on gsap library (#5330) feat: dynamically load ollama models (#5309) fix: skip temperature for goose-gpt-5 model (#5311) Replace compaction notifications with system notifications (#5218) Diagnostics (#5323) Fix gemini again (#5308) fix: synchronize local message state after conversation compaction (#5315) docs: replace broken links with working links (#5266) Add Web Accessibility Auditor recipe to cookbook (#5318) ...
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Oct 25, 2025
Signed-off-by: Blair Allan <[email protected]>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I am porting the changes in #4342 with some modification:
Type of Change
Testing
Manually verified on UI
Related Issues
Fixes #4273
Screenshots/Demos (for UX changes)
After:
