Remove reliance on localstorage for pendingScheduleDeepLink when scheduling a recipe #5290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOsinga
approved these changes
Oct 21, 2025
| } | ||
|
|
||
| // We don't need to handle pending deep links here anymore | ||
| // since we're handling them in the window creation flow |
| const [isRefreshing, setIsRefreshing] = useState(false); | ||
| const [pendingDeepLink, setPendingDeepLink] = useState<string | null>(null); | ||
|
|
||
| // Individual loading states for each action to prevent double-clicks |
Collaborator
There was a problem hiding this comment.
this is pre-existing code below, but it feels like we should just have a state per schedule, no?
Collaborator
Author
There was a problem hiding this comment.
yes good call, will come back to when we work on scheduler soon cc @amed-xyz
wpfleger96
added a commit
that referenced
this pull request
Oct 22, 2025
* main: (33 commits) Add Web Accessibility Auditor recipe to cookbook (#5318) To do mcp tutorial (#5317) workflows: add a manual trigger option to pr-smoke-test (#5302) documenting `goose recipe list` command (#5278) add a system prompt snapshot test (#5305) fix: handle non exist subrecipe path (#5287) Next camp (#5237) more lowercasing of TabItem labels (#5307) modified docs/tutorials/cicd Github Action's install path to follow download_cli script (#5240) Fix artifact download to work across workflow runs (#5304) Added extension search (#5283) docs: lowercase 'goose' in TabItem labels for consistency (#5297) feat(prompts): add format to save code snippet (#5007) fix: use Windows-compatible default path for CLI installation (#5221) feat: add Test Coverage Optimizer recipe (#5118) (#5272) Upgrade node to fix canary (#5301) Remove reliance on localstorage for pendingScheduleDeepLink when scheduling a recipe (#5290) Add historical tracking with trend indicators using artifacts (#5295) roll back vite and electron package upgrades breaking canary win and linux (#5292) Revert "Revert "Rewrite extension management tools"" (#5273) ...
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Oct 25, 2025
…duling a recipe (block#5290) Signed-off-by: Blair Allan <[email protected]>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
…duling a recipe (block#5290) Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up for #5217 to remove reliance on localStorage for pendingScheduleDeepLink